Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move multivariate polynomials over RR to libsingular #7577

Open
malb opened this issue Dec 1, 2009 · 7 comments
Open

move multivariate polynomials over RR to libsingular #7577

malb opened this issue Dec 1, 2009 · 7 comments

Comments

@malb
Copy link
Member

malb commented Dec 1, 2009

Singular supports real numbers as 'base field', we only need to implement the conversion routines.

CC: @burcin @nathanncohen

Component: commutative algebra

Author: Martin Albrecht

Issue created by migration from https://trac.sagemath.org/ticket/7577

@malb malb added this to the sage-5.11 milestone Dec 1, 2009
@malb malb self-assigned this Dec 1, 2009
@malb
Copy link
Member Author

malb commented Dec 1, 2009

comment:1

Attachment: mpolynomial_rr_libsingular.patch.gz

I am CCing burcin because he knows libSingular and I am CCing ncohen because I wrote this patch in order to speed up the linear programming interface.

@mwhansen
Copy link
Contributor

mwhansen commented Dec 2, 2009

comment:2

I get the following failures with this patch:

        sage -t  devel/sage-main/sage/matrix/matrix_sparse.pyx # 1 doctests failed
        sage -t  devel/sage-main/sage/calculus/desolvers.py # Segfault
        sage -t  devel/sage-main/sage/rings/polynomial/multi_polynomial.pyx # 2 doctests failed
        sage -t  devel/sage-main/sage/matrix/matrix_mpolynomial_dense.pyx # 2 doctests failed

@malb
Copy link
Member Author

malb commented Dec 2, 2009

comment:3

On what kind of machine?

@mwhansen
Copy link
Contributor

mwhansen commented Dec 2, 2009

comment:4

On sage.math. This is with the new Singular spkg from 7194.

@malb
Copy link
Member Author

malb commented Dec 2, 2009

comment:5

I can reproduce

sage -t  devel/sage-main/sage/matrix/matrix_sparse.pyx # 1 doctests failed
sage -t  devel/sage-main/sage/calculus/desolvers.py # Segfault
sage -t  devel/sage-main/sage/matrix/matrix_mpolynomial_dense.pyx # 2 doctests failed

but not

sage -t  devel/sage-main/sage/rings/polynomial/multi_polynomial.pyx # 2 doctests failed

I am attaching a fix for the failures I can reproduce.

@malb
Copy link
Member Author

malb commented Dec 2, 2009

comment:6

There is another issue: Singular uses MPF instead of MPFR to implement floating point numbers. Thus, we get less assurance about the precision with this new patch.

@jdemeyer
Copy link

comment:7

Attachment: mpolynomial_rr_libsingular_fixes.patch.gz

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@mkoeppe mkoeppe removed this from the sage-6.4 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants