Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation of rational_reconstruction incoherent with code #7710

Closed
zimmermann6 opened this issue Dec 16, 2009 · 3 comments
Closed

documentation of rational_reconstruction incoherent with code #7710

zimmermann6 opened this issue Dec 16, 2009 · 3 comments

Comments

@zimmermann6
Copy link

The documentation of rational_reconstruction says that an error
ZeroDivisionError is raised when no solution exists with the given
bounds, but the code returns an error ValueError.

Component: basic arithmetic

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/7710

@zimmermann6
Copy link
Author

comment:2

Still there in 4.3.1:

sage: rational_reconstruction?
...

        exists, that pair is unique and this function returns it. If no
        such pair exists, this function raises ZeroDivisionError.

and:

sage: rational_reconstruction(29,105)
...
ValueError: Rational reconstruction of 29 (mod 105) does not exist.

Note also that in 4.3.1 a.rational_reconstruction? gives a different documentation, which does
not mention what happens in case of error. Why are the documentations different?

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@jdemeyer
Copy link

comment:7

Fixed by #17180.

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants