Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph(g) and DiGraph(g) do not keep the embedding ! #7733

Closed
nathanncohen mannequin opened this issue Dec 18, 2009 · 11 comments
Closed

Graph(g) and DiGraph(g) do not keep the embedding ! #7733

nathanncohen mannequin opened this issue Dec 18, 2009 · 11 comments
Assignees
@rlmill
Labels
c: graph theory p: major / 3 t: bug
Milestone
sage-4.3.4

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Dec 18, 2009

Just try ::

sage: g = graphs.PetersenGraph()
sage: g.show()
sage: Graph(g).show()
sage: DiGraph(g).show()

The positions are not kept.... Why isn't Graph(g) equivalent to copy(g) ?

Nathann

Component: graph theory

Author: Nathann Cohen

Reviewer: Robert Miller

Merged: sage-4.3.4.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/7733
@nathanncohen nathanncohen mannequin added this to the sage-4.3.4 milestone Dec 18, 2009
@nathanncohen nathanncohen mannequin assigned rlmill Dec 18, 2009
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Feb 22, 2010

comment:1

Two lines !

Nathann

@nathanncohen nathanncohen mannequin added the s: needs review label Feb 22, 2010
@rlmill
Copy link
Mannequin

rlmill mannequin commented Mar 2, 2010

comment:2

You must provide doctests in both directions.

@rlmill rlmill mannequin added s: needs work and removed s: needs review labels Mar 2, 2010
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 2, 2010

comment:3

Done !

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 2, 2010

Attachment: trac_7733.patch.gz

@rlmill
Copy link
Mannequin

rlmill mannequin commented Mar 6, 2010

comment:4

There is one case which is untested, going from a Graph to a DiGraph.

@rlmill rlmill mannequin added s: needs work and removed s: needs review labels Mar 6, 2010
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 7, 2010

comment:5

What do you think of line 300 ?

sage: g = DiGraph(graphs.PetersenGraph())

Would you like to see an independent test for it ?

Nathann

@nathanncohen nathanncohen mannequin added s: needs info and removed s: needs work labels Mar 7, 2010
@rlmill
Copy link
Mannequin

rlmill mannequin commented Mar 7, 2010

comment:6

Sorry, I must have missed that!

@rlmill
Copy link
Mannequin

rlmill mannequin commented Mar 7, 2010

Reviewer: Robert Miller

@rlmill
Copy link
Mannequin

rlmill mannequin commented Mar 7, 2010

Author: Nathann Cohen

@rlmill rlmill mannequin added s: needs review and removed s: needs info labels Mar 7, 2010
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 7, 2010

comment:8

Thanks :-)

@mwhansen
Copy link
Contributor

mwhansen commented Mar 8, 2010

Merged: sage-4.3.4.alpha1

@mwhansen mwhansen closed this as completed Mar 8, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlmill rlmill

Labels
c: graph theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.3.4
Development

No branches or pull requests
1 participant
@mwhansen