Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscellaneous documentation fixes #7747

Closed
jhpalmieri opened this issue Dec 21, 2009 · 11 comments
Closed

miscellaneous documentation fixes #7747

jhpalmieri opened this issue Dec 21, 2009 · 11 comments

Comments

@jhpalmieri
Copy link
Member

With Sage 4.3.rc0, I get a few doctest failures from sage/doc, at least one of which is related to #7406. The attached patch fixes them. It also reinstates some doctests which were disabled until #5338 was fixed.

Oh, and it also changes a .. math block to match the actual LaTeX output from Sage.

I'm marking this as a blocker since without it, there are doctest failures.

Component: documentation

Author: John Palmieri, Burcin Erocal

Reviewer: Minh Van Nguyen

Merged: sage-4.3.rc1

Issue created by migration from https://trac.sagemath.org/ticket/7747

@jhpalmieri
Copy link
Member Author

Attachment: trac_7747-doc.patch.gz

@jhpalmieri

This comment has been minimized.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Dec 22, 2009

Reviewer: Minh Van Nguyen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Dec 22, 2009

Author: John Palmieri

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Dec 22, 2009

comment:2

Doctesting Sage 4.3.rc0 on sage.math results in the following failures:

sage -t -long devel/sage/doc/en/constructions/calculus.rst
**********************************************************************
File "/scratch/mvngu/sandbox/sage-4.3.rc0-7747-doc/devel/sage-main/doc/en/constructions/calculus.rst", line 29:
    sage: latex(f.diff(x))
Expected:
    k x^{3} e^{k x} \sin\left(w x\right) + w x^{3} e^{k x} \cos\left(w x\right) + 3 \, x^{2} e^{k x} \sin\left(w x\right)
Got:
    k x^{3} e^{\left(k x\right)} \sin\left(w x\right) + w x^{3} e^{\left(k x\right)} \cos\left(w x\right) + 3 \, x^{2} e^{\left(k x\right)} \sin\left(w x\right)
**********************************************************************
1 items had failures:
   1 of   6 in __main__.example_0
***Test Failed*** 1 failures.
For whitespace errors, see the file /tmp/mvngu/tmp/.doctest_calculus.py
         [5.6 s]

sage -t -long devel/sage/doc/en/bordeaux_2008/nf_introduction.rst
**********************************************************************
File "/scratch/mvngu/sandbox/sage-4.3.rc0-7747-doc/devel/sage-main/doc/en/bordeaux_2008/nf_introduction.rst", line 300:
    sage: latex(a)
Expected:
    -\frac{1}{2} \, {(I \, \sqrt{3} + 1)} ...
Got:
    -\frac{1}{2} \, {\left(I \, \sqrt{3} + 1\right)} {\left(\frac{1}{18} \, \sqrt{8 \, \sqrt{2} + 675} \sqrt{3} - \frac{5}{2}\right)}^{\left(\frac{1}{3}\right)} + \frac{1}{6} \, \frac{{\left(-I \, \sqrt{3} + 1\right)} \sqrt{2}\
}{{\left(\frac{1}{18} \, \sqrt{8 \, \sqrt{2} + 675} \sqrt{3} - \frac{5}{2}\right)}^{\left(\frac{1}{3}\right)}}
**********************************************************************
1 items had failures:
   1 of   7 in __main__.example_10
***Test Failed*** 1 failures.
For whitespace errors, see the file /tmp/mvngu/tmp/.doctest_nf_introduction.py
         [3.6 s]

The patch trac_7747-doc.patch fixes both of these failures. All doctests now pass on sage.math.

@jhpalmieri
Copy link
Member Author

comment:3

This is a duplicate of #7659, but the patch here does a little more. Can we use this patch instead of that one?

@mwhansen
Copy link
Contributor

comment:4

I've merged the patch here instead of the one at #7659.

@mwhansen
Copy link
Contributor

Merged: sage-4.3.rc1

@jhpalmieri
Copy link
Member Author

comment:5

Could you please make sure that burcin also gets author credit for this (for his work on #7659)? Thanks.

@mwhansen
Copy link
Contributor

comment:6

Done.

@mwhansen
Copy link
Contributor

Changed author from John Palmieri to John Palmieri, Burcin Erocal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants