Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search_doc: print warning if some Sage docs are missing #7750

Closed
jhpalmieri opened this issue Dec 22, 2009 · 4 comments
Closed

search_doc: print warning if some Sage docs are missing #7750

jhpalmieri opened this issue Dec 22, 2009 · 4 comments

Comments

@jhpalmieri
Copy link
Member

If you call search_doc and one piece of the Sage docs are missing, this patch prints the following warning (and then proceeds with the search):

sage: search_doc('factorial')
Warning, the following Sage documentation hasn't been built,
so documentation search results may be incomplete:

/Applications/sage/devel/sage/doc/output/html/fr/tutorial

You can build this with 'sage -docbuild fr/tutorial html'.

If more than one piece is missing, it prints this warning:

sage: search_doc('factorial')
Warning, the following Sage documentation hasn't been built,
so documentation search results may be incomplete:

/Applications/sage/devel/sage/doc/output/html/en/developer
/Applications/sage/devel/sage/doc/output/html/en/installation
/Applications/sage/devel/sage/doc/output/html/fr/tutorial

You can build these with 'sage -docbuild DOCUMENT html',
where DOCUMENT is one of 'developer', 'installation', 'fr/tutorial', 
or you can use 'sage -docbuild all html' to build all of the missing documentation.

You can test this by installing the patch and selectively deleting and building pieces of the documentation. You don't need to restart Sage between deletions or builds -- do that in another window, and each call to search_doc will check for existence of the docs each time.

There are no doctests for this, because I think that doctests should assume that the Sage build is complete: all documentation should be assumed to be built.

Component: documentation

Author: John Palmieri

Reviewer: William Stein

Merged: sage-4.3.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7750

@jhpalmieri
Copy link
Member Author

Attachment: trac_7750-search-doc.patch.gz

@williamstein
Copy link
Contributor

comment:2

This is awesome. Positive review.

@mwhansen
Copy link
Contributor

mwhansen commented Jan 4, 2010

Merged: sage-4.3.1.alpha0

@mwhansen
Copy link
Contributor

mwhansen commented Jan 4, 2010

Reviewer: William Stein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants