Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved docs and INI support at /interfaces/povray.py #7792

Open
sagetrac-slosoi mannequin opened this issue Dec 29, 2009 · 9 comments
Open

Improved docs and INI support at /interfaces/povray.py #7792

sagetrac-slosoi mannequin opened this issue Dec 29, 2009 · 9 comments

Comments

@sagetrac-slosoi
Copy link
Mannequin

sagetrac-slosoi mannequin commented Dec 29, 2009

To improve docs of Povray, support for inifile.

Component: interfaces

Keywords: povray

Author: Sami Losoi

Reviewer: mhampton, boothby

Issue created by migration from https://trac.sagemath.org/ticket/7792

@sagetrac-slosoi sagetrac-slosoi mannequin added this to the sage-5.11 milestone Dec 29, 2009
@sagetrac-slosoi
Copy link
Mannequin Author

sagetrac-slosoi mannequin commented Dec 30, 2009

comment:3

There are some bugs apparently in the width and height parameters in the changed code.
The parameters F and P work differently as I expected.

@sagetrac-slosoi
Copy link
Mannequin Author

sagetrac-slosoi mannequin commented Dec 30, 2009

Attachment: povray.py.gz

@sagetrac-slosoi
Copy link
Mannequin Author

sagetrac-slosoi mannequin commented Dec 30, 2009

comment:4

Replying to @sagetrac-slosoi:

There are some bugs apparently in the width and height parameters in the changed code.
The parameters F and P work differently as I expected.

The patch -file is old one. I will submit a new one after the compilation of Sage.

@sagetrac-slosoi

This comment has been minimized.

@sagetrac-slosoi sagetrac-slosoi mannequin changed the title Improved docs and added Width and Height at /interfaces/povray.py Improved docs and INI support at /interfaces/povray.py Dec 30, 2009
@sagetrac-slosoi
Copy link
Mannequin Author

sagetrac-slosoi mannequin commented Dec 30, 2009

Attachment: povray_doc.2.patch.gz

@sagetrac-slosoi
Copy link
Mannequin Author

sagetrac-slosoi mannequin commented Dec 30, 2009

Attachment: povray_doc.patch.gz

@sagetrac-mhampton
Copy link
Mannequin

sagetrac-mhampton mannequin commented Feb 7, 2010

comment:6

Why are you removing the docstring from the class definition?

@boothby
Copy link

boothby commented Jun 23, 2010

Reviewer: mhampton, boothby

@boothby
Copy link

boothby commented Jun 23, 2010

comment:7

Somethings up with these patches. Both povray_doc.patch and povray_doc.2.patch are identical and won't apply on top of povray.py. Also, the file is missing class-level documentation and doctests, (as mhampton noted, you should move the file-level doc back) and nothing is doctested in the methods.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@mkoeppe mkoeppe removed this from the sage-6.4 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants