Move mip_coin and mip_glpk to Sage

[nathanncohen]

Hello !!

This patches moves the files mip_coin and mip_glpk to Sage. They are currently included in the packages CBC and GLPK and are a lot harder to work on because of this.

This patch copies them in sage/numerical/ and adds several lines to modules_list so that they will only be compiled if the corresponding packages are installed.

For the moment, the copies of these files included in the packages will not be removed, in order to preserve backward-compatibility : the users of earlier versions of Sage will then be able to keep using the same packages.

*Only the changes to file modules_list need to be reviewed -- mip_coin and mip_glpk are copies of what is included in the spkg and have already been checked ! This should be a short review :-) *

CC: @sagetrac-mvngu

Component: numerical

Author: Nathann Cohen

Reviewer: Robert Miller

Merged: sage-4.3.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/7804

[williamstein]

comment:5

I was curious and skimmed this patch for ~ 3 minutes and it "looks good" (not a positive review -- I didn't test it yet).

[nathanncohen]

comment:6

Attachment: trac_7804.patch.gz

I just modified it so that it is now independent from the huge changes going on in graph.py. Would it be possible to have this merged to the next release ? It would let me write another speed-up patch now that solve_glpk and solve_cbc are available ;-)

Nathann

[rlmill]

Merged: 4.3.1.alpha2

[rlmill]

Author: Nathann Cohen

[rlmill]

comment:7

positive review

[rlmill]

Reviewer: Robert Miller

[nathanncohen]

comment:8

Yessssssssssss !! :-) Thanks !!!!

Nathann

[sagetrac-mvngu]

Changed merged from 4.3.1.alpha2 to sage-4.3.1.alpha2

[jhpalmieri]

comment:10

How did this get a positive review when the new pyx files have no doctests?

[rlmill]

comment:11

That's a good point-- I suppose my review was a bit rushed.

Nathann,

Do you want to make a separate ticket for making some doctests here, or would you prefer it if I just pull the patch back out?

[nathanncohen]

comment:12

see #7925 :-)

But they will be way harder to write with the spkg GLPK and cbc broken :-/

Nathann