Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change $MKDIR to 'mkdir' in pari #7901

Closed
sagetrac-drkirkby mannequin opened this issue Jan 12, 2010 · 8 comments
Closed

Change $MKDIR to 'mkdir' in pari #7901

sagetrac-drkirkby mannequin opened this issue Jan 12, 2010 · 8 comments

Comments

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jan 12, 2010

It was agreed recently that variables would not be used for very common commands like MV, MKDIR etc.

 http://groups.google.com/group/sage-devel/browse_thread/thread/bd7ae07a1157bead/970aa0dc8fa56ab7?lnk=raot

#7818 usets these, so this package may break. The fix is to simply replace $MKDIR with 'mkdir' in spkg-install.

An updated .spkg can be found at

http://boxen.math.washington.edu/home/kirkby/portability/pari-2.3.3.p7/pari-2.3.3.p7.spkg

CC: @jaapspies @jhpalmieri

Component: build

Author: David Kirkby

Reviewer: Jaap Spies

Merged: sage-4.3.1.rc0

Issue created by migration from https://trac.sagemath.org/ticket/7901

@sagetrac-drkirkby sagetrac-drkirkby mannequin added this to the sage-4.3.1 milestone Jan 12, 2010
@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Jan 12, 2010

Author: David Kirkby

@sagetrac-drkirkby

This comment has been minimized.

@jaapspies
Copy link
Member

comment:3

The patch of spkg-install looks ok. Maybe the SPKG.txt should be brought up to date.

See also: #7738

Dave, can you fix that?

Jaap

@jaapspies
Copy link
Member

Reviewer: Jaap Spies

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Jan 12, 2010

comment:4

OK I've recreated the spkg, which again can be found at http://boxen.math.washington.edu/home/kirkby/portability/pari-2.3.3.p7/pari-2.3.3.p7.spkg Please check it again.

I've attached the Mercurial patch, which overwrites the old one.

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Jan 12, 2010

Attachment: pari-variables-to-commands.patch.gz

Updated patch to fix spkg-install and SPKG.txt

@jaapspies
Copy link
Member

comment:5

All fixed. Positive review.

Jaap

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 14, 2010

Merged: sage-4.3.1.rc0

@rlmill rlmill mannequin removed the s: positive review label Jan 14, 2010
@rlmill rlmill mannequin closed this as completed Jan 14, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant