Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_square() should be False for negative algebraic reals #7906

Closed
robertwb opened this issue Jan 12, 2010 · 7 comments
Closed

is_square() should be False for negative algebraic reals #7906

robertwb opened this issue Jan 12, 2010 · 7 comments
Assignees
@aghitza
Labels
c: algebra p: major / 3 t: bug
Milestone
sage-4.3.1

Comments

@robertwb
Copy link
Contributor

See http://groups.google.com/group/sage-nt/browse_thread/thread/23233a74a1037264

Component: algebra

Author: Robert Bradshaw

Reviewer: John Cremona

Merged: sage-4.3.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/7906
@robertwb robertwb added this to the sage-4.3.1 milestone Jan 12, 2010
@robertwb
Copy link
Contributor Author

Attachment: 7906-AA-is_square.patch.gz

@JohnCremona
Copy link
Member

replaces previous

@JohnCremona
Copy link
Member

Reviewer: John Cremona

@JohnCremona
Copy link
Member

Author: Robert Bradshaw

@JohnCremona
Copy link
Member

comment:1

Attachment: 7906-AA-is_square-2.patch.gz

Positive review. I took the liberty of adding to the patch correction of a typo which I fixed once but somehow got lost in the patches (merged in 4.3.1.alpha1) at #6887, which I came up against while testing, and which has come up on sage-devel (or perhaps sage-support) where I will report back.

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 13, 2010

Merged: 4.3.1.alpha2

@rlmill rlmill mannequin removed the s: positive review label Jan 13, 2010
@rlmill rlmill mannequin closed this as completed Jan 13, 2010
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 13, 2010

Changed merged from 4.3.1.alpha2 to sage-4.3.1.alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghitza aghitza

Labels
c: algebra p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.3.1
Development

No branches or pull requests
3 participants
@robertwb @aghitza @JohnCremona