Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace $MKDIR with 'mkdir' in sage-spkg #7909

Closed
sagetrac-drkirkby mannequin opened this issue Jan 12, 2010 · 9 comments
Closed

Replace $MKDIR with 'mkdir' in sage-spkg #7909

sagetrac-drkirkby mannequin opened this issue Jan 12, 2010 · 9 comments

Comments

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jan 12, 2010

sage-spkg has $MKDIR in one place, which will cause problems with an updated 'sage-env' which no longer defines MKDIR.

I'm attaching a copy of the revised sage-spkg, and also a Mercurial patch.

CC: @jaapspies

Component: build

Author: David Kirkby

Reviewer: Jaap Spies

Merged: sage-4.3.1.rc0

Issue created by migration from https://trac.sagemath.org/ticket/7909

@sagetrac-drkirkby sagetrac-drkirkby mannequin added this to the sage-4.3.1 milestone Jan 12, 2010
@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Jan 12, 2010

Attachment: sage-spkg.gz

A complete copy of the revised sage-env

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Jan 12, 2010

Mercurial patch for sage-env

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Jan 12, 2010

comment:1

Attachment: sage-spkg-remove-MKDIR.patch.gz

@jaapspies
Copy link
Member

Reviewer: Jaap Spies

@jaapspies
Copy link
Member

comment:2

Don't know whether the name 'sage-spkg' is any good. Did you mean to attach the new sage-env?

The patch is simple and looks good.

Jaap

@jaapspies
Copy link
Member

comment:3

Replying to @jaapspies:

Don't know whether the name 'sage-spkg' is any good. Did you mean to attach the new sage-env?

The patch is simple and looks good.

Jaap

It is really in sage-spkg!! I changed the description.

Waiting for the mercurial patch.

Jaap

@jaapspies

This comment has been minimized.

@jaapspies
Copy link
Member

comment:4

The "mercurial patch" is ok. sage-spkg looks good. So positive review.

Jaap

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 14, 2010

Merged: sage-4.3.1.rc0

@rlmill rlmill mannequin removed the s: positive review label Jan 14, 2010
@rlmill rlmill mannequin closed this as completed Jan 14, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant