Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QQbar should accept number field elements with embeddings #7960

Closed
robertwb opened this issue Jan 17, 2010 · 8 comments
Closed

QQbar should accept number field elements with embeddings #7960

robertwb opened this issue Jan 17, 2010 · 8 comments

Comments

@robertwb
Copy link
Contributor

One should be able to do

sage: K.<a> = NumberField(x^3-x+1, embedding=-1.32)
sage: QQbar(a)
-1.324717957244746?

Followup to #4621

CC: @videlec

Component: number theory

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/7960

@robertwb robertwb added this to the sage-5.11 milestone Jan 17, 2010
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@videlec
Copy link
Contributor

videlec commented Feb 26, 2015

comment:5

cc'ing me.

The function sage.rings.number_field.number_field_morphisms.create_embedding_from_approx should really be smarter. This is related to what I am currently doing in #17830.

@mezzarobba
Copy link
Member

comment:6

Fixed in #13041.

@mezzarobba mezzarobba removed this from the sage-6.4 milestone Sep 22, 2018
@pjbruin
Copy link
Contributor

pjbruin commented Nov 9, 2018

comment:8

The requested example now works. It would be even nicer to also have a coercion map from K to QQbar, but currently we do not have this:

sage: K.<a> = NumberField(x^3 - x + 1, embedding=-1.32)
sage: QQbar(a)
-1.324717957244746?
sage: QQbar.coerce_map_from(K) is None
True

@pjbruin
Copy link
Contributor

pjbruin commented Nov 9, 2018

Reviewer: Peter Bruin

@pjbruin
Copy link
Contributor

pjbruin commented Nov 9, 2018

comment:9

Replying to @pjbruin:

It would be even nicer to also have a coercion map from K to QQbar

OK, there is already a ticket for this: #5355. Positive review for this one.

@embray
Copy link
Contributor

embray commented Feb 26, 2019

comment:10

Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Feb 26, 2019

comment:11

Just fixing the example in the ticket description so anyone can check this now works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants