New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Giving some punch to distance computations #7966
Comments
comment:2
Small modification to distance_graph too: Before :
After
Nathann |
comment:3
The speedups are great, but I got one extra failure (against 4.3.3 on Fedora 12):
Please could you look at this? |
Reviewer: Paul Zimmermann |
comment:4
At first, the function associated a path from v to each other vertex, possibly empty if there was none. Then I noticed the other functions in Sage expected the dictionary to only contain keys corresponding to the vertices reachable from v (which was sound, too), and changed the original function, forgetting the docstrings... Fixed now ! And I also removed the (commented) loop which was associating empty paths when needed... Thank you again ! :-) Nathann |
comment:5
Attachment: trac_7966.patch.gz with the new patch
Thus a positive review. Paul |
Author: Nathann Cohen |
Merged: sage-4.3.4.alpha0 |
This patch creates a function shortest_path_all_vertices in c_graphs which, given a vertex v, computes a shortest path for each other vertex.
With small other modifications, it improves the speed of many functions ( which were all calling each other )
Before :
After
Nathann
Component: graph theory
Author: Nathann Cohen
Reviewer: Paul Zimmermann
Merged: sage-4.3.4.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/7966
The text was updated successfully, but these errors were encountered: