Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doctest in base.pyx #7985

Closed
sagetrac-wcauchois mannequin opened this issue Jan 19, 2010 · 5 comments
Closed

fix doctest in base.pyx #7985

sagetrac-wcauchois mannequin opened this issue Jan 19, 2010 · 5 comments

Comments

@sagetrac-wcauchois
Copy link
Mannequin

sagetrac-wcauchois mannequin commented Jan 19, 2010

The following doctest from line 757 of base.pyx:

sage: G = tetrahedron(color='red') + tetrahedron(color='yellow') + tetrahedron(color='red', opacity=0.5)
sage: G.texture_set()
set([Texture(texture..., red, ff0000), Texture(texture..., yellow, ffff00), Texture(texture..., red, ff0000)])

will fail sometimes because the order of the elements of the set is not fixed. The attached patch fixes this by outputting first the two red textures, and then the yellow texture.

Component: graphics

Author: Bill Cauchois

Reviewer: Willem Jan Palenstijn

Merged: sage-4.3.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/7985

@sagetrac-wcauchois sagetrac-wcauchois mannequin added this to the sage-4.3.1 milestone Jan 19, 2010
@sagetrac-wcauchois
Copy link
Mannequin Author

sagetrac-wcauchois mannequin commented Jan 19, 2010

based on sage 4.3.1.rc0

@wjp
Copy link
Mannequin

wjp mannequin commented Jan 19, 2010

comment:1

Attachment: fix-annoying-doctest.patch.gz

@wjp wjp mannequin added the s: needs review label Jan 19, 2010
@wjp
Copy link
Mannequin

wjp mannequin commented Jan 19, 2010

comment:2

Looks good.

@wjp wjp mannequin added s: positive review and removed s: needs review labels Jan 19, 2010
@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 19, 2010

Merged: sage-4.3.1.rc1

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 19, 2010

Reviewer: Willem Jan Palenstijn

@rlmill rlmill mannequin removed the s: positive review label Jan 19, 2010
@rlmill rlmill mannequin closed this as completed Jan 19, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant