New pycrypto-2.0.1.p5.spkg builds 64-bit with Open Solaris x64.

[jaapspies]

Let SAGE64="yes" work with Open Solaris 64 bit too.

The spkg is here:
http://boxen.math.washington.edu/home/jsp/ports/pycrypto-2.0.1.p5.spkg

byte-compiling /export/home/jaap/Downloads/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/__init__.py to __init__.pyc
running install_egg_info
Writing /export/home/jaap/Downloads/sage-4.3.1/local/lib/python2.6/site-packages/pycrypto-2.0.1-py2.6.egg-info

real	0m5.851s
user	0m4.285s
sys	0m0.920s
Successfully installed pycrypto-2.0.1.p5
You can safely delete the temporary build directory
/export/home/jaap/Downloads/sage-4.3.1/spkg/build/pycrypto-2.0.1.p5
Making Sage/Python scripts relocatable...
Making script relocatable
Finished installing pycrypto-2.0.1.p5.spkg
jaap@opensolaris:~/Downloads/sage-4.3.1$ 

Jaap

Component: porting

Author: Jaap Spies

Reviewer: David Kirkby

Merged: sage-4.3.3.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8070

[jaapspies]

Attachment: pycrypto-2.0.1.p5.patch.gz

[sagetrac-drkirkby]

comment:2

It has 'echo "64 bit MacIntel" which is not correct.

[sagetrac-drkirkby]

Reviewer: David Kirkby

[jaapspies]

comment:3

Attachment: pycrypto-2.0.1.p5+.patch.gz

Done.

Jaap

[sagetrac-drkirkby]

comment:4

That's fine. In future, it would be helpful if you could show evidence that the package is building ok, as

Successfully installed pycrypto-2.0.1.p5

does not prove very much. Plenty of packages claim to 'sucessfully' install in Open Solaris, yet in practice they do not. In this case, we can see:

copying build/lib.solaris-2.11-i86pc-2.6/Crypto/Cipher/AES.so -> /export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher
copying build/lib.solaris-2.11-i86pc-2.6/Crypto/Cipher/DES3.so -> /export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher
copying build/lib.solaris-2.11-i86pc-2.6/Crypto/Cipher/DES.so -> /export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher

and using 'file' in the directory, I can indeed see the binaries are now 64-bit.

drkirkby@hawk:~/sage-4.3.1$ file /export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/*
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/AES.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/ARC2.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/ARC4.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/Blowfish.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/CAST.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/DES3.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/DES.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/IDEA.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/__init__.py:	English text
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/__init__.pyc:	data
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/RC5.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
/export/home/drkirkby/sage-4.3.1/local/lib/python2.6/site-packages/Crypto/Cipher/XOR.so:	ELF 64-bit LSB dynamic lib AMD64 Version 1, dynamically linked, not stripped
drkirkby@hawk:~/sage-4.3.1$ 

So a positive review from me.

Sorry to sometimes ask for extra things, but it is easier for the reviewer if he can see evidence this fixes the bug. As I've done many of these Solaris fixes, and see some from you, I can see ways of improving some things.

Dave

[qed777]

Merged: sage-4.3.3.alpha0