Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding of prefixes and palindrome prefixes iterators to the Words library #8093

Closed
sagetrac-abmasse mannequin opened this issue Jan 27, 2010 · 10 comments
Closed

Adding of prefixes and palindrome prefixes iterators to the Words library #8093

sagetrac-abmasse mannequin opened this issue Jan 27, 2010 · 10 comments

Comments

@sagetrac-abmasse
Copy link
Mannequin

sagetrac-abmasse mannequin commented Jan 27, 2010

Adds three functions to iterate over prefixes and palindrome prefixes of finite and infinite words.

CC: @seblabbe

Component: combinatorics

Keywords: palindrome, prefix

Author: Alexandre Blondin Massé

Reviewer: Sébastien Labbé

Merged: sage-4.3.3.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8093

@sagetrac-abmasse sagetrac-abmasse mannequin added this to the sage-4.3.3 milestone Jan 27, 2010
@sagetrac-abmasse sagetrac-abmasse mannequin self-assigned this Jan 27, 2010
@sagetrac-abmasse
Copy link
Mannequin Author

sagetrac-abmasse mannequin commented Jan 31, 2010

Updated to synchronize with sage-combinat mercurial repository -- should be the same file

@seblabbe
Copy link
Contributor

Attachment: trac_8093_palindromes_prefixes-abm.patch.gz

Applies over the precedent patch

@seblabbe
Copy link
Contributor

Reviewer: Sébastien Labbé

@seblabbe
Copy link
Contributor

Author: Alexandre Blondin-Massé

@seblabbe
Copy link
Contributor

comment:2

Attachment: trac_8093_doc_fixes-sl.patch.gz

All tests passed in sage/combinat/words. Doc builds fine. Code is good.

I added a small patch that edits the INPUT block and adds a TEST.

Positive review.

@sagetrac-abmasse
Copy link
Mannequin Author

sagetrac-abmasse mannequin commented Jan 31, 2010

comment:3

Alright with the modifs as far as I'm concerned.

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 11, 2010

Merged: sage-4.3.3.alpha0

@qed777 qed777 mannequin removed the s: positive review label Feb 11, 2010
@qed777 qed777 mannequin closed this as completed Feb 11, 2010
@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 11, 2010

comment:5

I'm updating the Author field per the main wiki page. Please let us know if they're wrong.

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 11, 2010

Changed author from Alexandre Blondin-Massé to Alexandre Blondin Massé

@sagetrac-abmasse
Copy link
Mannequin Author

sagetrac-abmasse mannequin commented Feb 11, 2010

comment:6

Thanks, this is indeed the right name (without dash).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant