Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developer's guide for making spkgs should specify that patches need to be version controlled #8104

Closed
dandrake opened this issue Jan 28, 2010 · 2 comments

Comments

@dandrake
Copy link
Contributor

When working on a spkg and adding or modifying patches, the developers' guide (http://www.sagemath.org/doc/developer/producing_spkgs.html) should remind developers to version-control the patches.

19:38 < gsmcwhirter> if some or all of the existing patches no
  longer apply, should they be left there or deleted? (on networkx, 
  there was an edit to a file to switch from numerix to numpy, but 
  the latest upstream source uses numpy by default)
19:39 < ddrake> I'd delete obsolete patches, and mention that you 
  did so in SPKG.txt.
19:48 < ddrake> also note that the patches/ directory is version 
  controlled, so make sure you 'hg add' new patches and 'hg rm' 
  unneeded ones.
19:51 < mvngu> ddrake: That looks like a sensible thing to do. But 
  it's not documented at http://www.sagemath.org/doc/developer
  /producing_spkgs.html. 
19:51 < mvngu> ddrake: Could you open a ticket for this and CC me 
  on it?
19:51 < ddrake> sure. 
19:52 < ddrake> the documentation you just linked to does say "Make 
  sure that the hg repo contains every file outside the src 
  directory, and that these are all up-to-date and commited into 
  the repo."
19:52 < ddrake> but perhaps patches bear a special mention, just to 
  make it clear. I'll open the ticket.

CC: @sagetrac-mvngu

Component: documentation

Issue created by migration from https://trac.sagemath.org/ticket/8104

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 9, 2010

comment:1

A patch addressing this issue is up at #8079.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 14, 2010

comment:2

Close as fixed by #8079.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant