New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcd of rationals is trouble #8111
Comments
comment:1
I think the trouble here is our generic fraction field code, not how we define the gcd of rational numbers. For efficiency, we should represent QQ(x) as Frac(ZZ[x]), and do the necessary normalisation of the denominator (it should be monic) when the user accesses it with |
comment:2
#10771 is probably related/same thing. |
comment:4
Replying to @simon-king-jena:
PS: It seems to me that for changing gcd for univariate polynomials over the rationals, one has to dive into flint. I'll not do that, it'd be too far off topic for me. BTW, the doc string explicitly states that gcd in |
comment:9
Possibly related: this discussion. |
Stopgaps: todo |
This comment has been minimized.
This comment has been minimized.
Changed keywords from none to sd109 |
Author: Jonathan Kliem |
Changed author from Jonathan Kliem to none |
comment:12
If this is fixed, we should probably have a doctest then. Unless it wasn't an error to begin with? Or it's possible it was fixed elsewhere and doctested, which is fine too. |
Commit: |
New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch: public/8111 |
Author: Jonathan Kliem |
Reviewer: Matthias Koeppe |
comment:16
Thank you. |
Changed branch from public/8111 to |
The following was solved along the way. We add a doctest.
The GCD of rationals is still unclear (see trac 3214), and leads to definite problems with reduce().
gives
The last line in particular is false, according to me.
Component: basic arithmetic
Keywords: sd109
Stopgaps: todo
Author: Jonathan Kliem
Branch/Commit:
bed3abb
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/8111
The text was updated successfully, but these errors were encountered: