Sage patches added directly to symmetica source

[sagetrac-drkirkby]

The symmerica package says in SPKG.txt

== Special Update/Build Instructions ==

Against common policy the patches in the patches directory have been applied to 
the src directory:

 * de.patch (Turn off banner)
 * macro.h.patch (Change some return types, this can be avoided)
 * makefile.patch (Fix compiler, inject CFLAGS)
 * sort_sum_rename.patch (rename sort tp sym_sort, sum to sym_sum) 

It would appear various patches have been made to the source code.

http://boxen.math.washington.edu/home/kirkby/portability/symmetrica-2.0.p5/

has an updated version of symmetica, which will build with any compiler, and in 64-bit mode. However, it does not resolve the issue of patching the source directly. I modified the makefile, which had already been modified before. A patch was left, so I have tried to recreate the original makefile. But other files have been changed too. The packages is basically a bit of a mess

CC: @jaapspies @sagetrac-mvngu

Component: build

Reviewer: David Kirkby, Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/8122

[kini]

comment:1

Has this been fixed already? Looks like the text you quoted no longer exists in SPKG.txt in symmetrica-2.0.p7.spkg, which currently ships with Sage.

[jdemeyer]

comment:4

Duplicate of #10719.

[jdemeyer]

Reviewer: Jeroen Demeyer

[jdemeyer]

Changed reviewer from Jeroen Demeyer to David Kirkby, Jeroen Demeyer

[jdemeyer]

Changed author from David Kirkby to none