Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot convert residue field elements back to p-adic ring #8181

Closed
sagetrac-dmharvey mannequin opened this issue Feb 3, 2010 · 19 comments
Closed

cannot convert residue field elements back to p-adic ring #8181

sagetrac-dmharvey mannequin opened this issue Feb 3, 2010 · 19 comments

Comments

@sagetrac-dmharvey
Copy link
Mannequin

sagetrac-dmharvey mannequin commented Feb 3, 2010

I should be able to coerce elements of the residue field of a p-adic ring back into the ring, but I can't:

sage: R.<z> = Zq(9)
sage: F = R.residue_class_field()
sage: F
Finite Field in z0 of size 3^2
sage: a = F.gen()
sage: R(a)
---------------------------------------------------------------------------
TypeError

CC: @roed314 @orlitzky

Component: padics

Keywords: days71

Author: Julian Rüth

Branch/Commit: 7ab36c6

Reviewer: Aly Deines

Issue created by migration from https://trac.sagemath.org/ticket/8181

@sagetrac-dmharvey
Copy link
Mannequin Author

sagetrac-dmharvey mannequin commented Feb 3, 2010

@orlitzky
Copy link
Contributor

comment:2

This works now:

sage: R.<z> = Zq(9)
sage: F = R.residue_class_field()
sage: F
Finite Field in z0 of size 3^2
sage: a = F.gen()
sage: R(a)
z + O(3)

I can create a patch with a doctest, but I don't know if the result is correct. Does it look about right?

@saraedum saraedum changed the title cannot coerce residue field back to p-adic ring cannot convert residue field elements back to p-adic ring Mar 20, 2016
@saraedum
Copy link
Member

@saraedum
Copy link
Member

@saraedum
Copy link
Member

comment:5

It was fixed in the meantime. A added a standard test for it.

@saraedum
Copy link
Member

Author: Julian Rüth

@saraedum
Copy link
Member

Commit: 40900ca

@saraedum
Copy link
Member

New commits:

40900caTest lifting to p-adic rings

@saraedum
Copy link
Member

@adeines
Copy link
Mannequin

adeines mannequin commented Mar 21, 2016

Reviewer: Aly Deines

@adeines
Copy link
Mannequin

adeines mannequin commented Mar 21, 2016

comment:8

Looks good.

@adeines
Copy link
Mannequin

adeines mannequin commented Mar 23, 2016

Changed keywords from none to sd71

@adeines
Copy link
Mannequin

adeines mannequin commented Mar 23, 2016

Changed keywords from sd71 to days71

@jdemeyer
Copy link

jdemeyer commented Apr 4, 2016

comment:11

Doesn't apply according to the patchbot.

@jdemeyer jdemeyer added this to the sage-7.2 milestone Apr 4, 2016
@roed314
Copy link
Contributor

roed314 commented Nov 20, 2016

@roed314
Copy link
Contributor

roed314 commented Nov 20, 2016

comment:13

Fixed the merge problem.


New commits:

7ab36c6Merge branch 'u/saraedum/cannot_convert_residue_field_elements_back_to_p_adic_ring' of git://trac.sagemath.org/sage into develop

@roed314
Copy link
Contributor

roed314 commented Nov 20, 2016

Changed commit from 40900ca to 7ab36c6

@saraedum
Copy link
Member

comment:15

The increase in startup reported by the patchbot is just noise.

@vbraun
Copy link
Member

vbraun commented Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants