Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%time now hugely broken in sagenb-0.7.4 (sage-4.3.2) #8225

Closed
williamstein opened this issue Feb 10, 2010 · 7 comments
Closed

%time now hugely broken in sagenb-0.7.4 (sage-4.3.2) #8225

williamstein opened this issue Feb 10, 2010 · 7 comments

Comments

@williamstein
Copy link
Contributor



On Tue, Feb 9, 2010 at 1:22 PM, finotti <luis.finotti@gmail.com> wrote:
> Dear all,
>
> Cells starting with "%time" stopped working with 4.3.2.  (It works
> with 4.3.1.)  Is it no long supported or is it a bug? (time still
> works with the command line.)
>
> Running on Linux 32-bit, ubuntu binary.
>
> Thanks,

Wow, what a horrible, horrible regression! Indeed, I've confirmed that what happens is that doing %time causes the notebook to hang forever, and be pretty broken thereafter. Ouch. The issue was reported at these sage-support and sage-notebook threads.

Component: notebook

Author: Mitesh Patel

Reviewer: William Stein

Merged: sagenb-0.7.5.3

Issue created by migration from https://trac.sagemath.org/ticket/8225

@sagetrac-mvngu

This comment has been minimized.

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 14, 2010

Attachment: trac_8225-timeit_notebook.patch.gz

Fix %time and %timeit. sagenb repo.

@qed777 qed777 mannequin added the s: needs review label Feb 14, 2010
@dandrake
Copy link
Contributor

comment:3

I can confirm that this patch fixes the problem with %time on 4.3.3, and %timeit also works, but doesn't work as it does on the command line -- there, %timeit runs multiple loops and so on. Is that how %timeit has always worked in the notebook?

I don't know this particular code very well, but the patch appears to fix the problem and seems okay. So consider this a quite weak positive review.

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 23, 2010

comment:4

I think %timeit has worked that way in the notebook. See this sage-devel thread. The worksheet I mentioned is now here.

@mwhansen
Copy link
Contributor

mwhansen commented Mar 7, 2010

Reviewer: William Stein

@mwhansen
Copy link
Contributor

mwhansen commented Mar 7, 2010

Author: Mitesh Patel

@qed777
Copy link
Mannequin

qed777 mannequin commented Mar 9, 2010

Merged: sagenb-0.7.5.3

@qed777 qed777 mannequin removed the s: positive review label Mar 9, 2010
@qed777 qed777 mannequin closed this as completed Mar 9, 2010
@qed777 qed777 mannequin mentioned this issue Mar 9, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants