Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra parenthesis when typesetting QQ arguments to symbolic functions #8297

Closed
burcin opened this issue Feb 18, 2010 · 11 comments
Closed

extra parenthesis when typesetting QQ arguments to symbolic functions #8297

burcin opened this issue Feb 18, 2010 · 11 comments

Comments

@burcin
Copy link

burcin commented Feb 18, 2010

From sage-devel:

On Wed, 17 Feb 2010 23:16:13 -0800 (PST)
Håkan Granath <hakan.granath@googlemail.com> wrote:

> A minor inconvenience is the extra set of parentheses that appear
> when typesetting QQ elements as arguments of functions, e.g.
> 
> ----------------------------------------------------------------------
> | Sage Version 4.3.2, Release Date: 2010-02-06                       |
> | Type notebook() for the GUI, and license() for information.        |
> ----------------------------------------------------------------------
> sage: latex(gamma(1/4))
> \Gamma\left(\left(\frac{1}{4}\right)\right)
> 
> 
> Unfortunately I can not create a patch myself to fix this since
> I could not figure out where the problem comes from.
> 
> /Håkan

Here is the thread:

http://groups.google.com/group/sage-devel/t/d068d2fd544eadde

Component: symbolics

Author: Burcin Erocal

Reviewer: Håkan Granath

Merged: sage-4.4.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8297

@burcin burcin added this to the sage-4.4 milestone Feb 18, 2010
@burcin burcin self-assigned this Feb 18, 2010
@burcin
Copy link
Author

burcin commented Apr 2, 2010

@burcin
Copy link
Author

burcin commented Apr 2, 2010

Author: Burcin Erocal

@burcin
Copy link
Author

burcin commented Apr 2, 2010

Changed keywords from pynac to none

@burcin
Copy link
Author

burcin commented Apr 2, 2010

comment:1

The fix for this was much easier than I expected. It didn't require any changes in pynac. :)

@sagetrac-hgranath
Copy link
Mannequin

sagetrac-hgranath mannequin commented Apr 11, 2010

comment:2

The patch works, I have checked that it passes all tests, and html and
pdf manual builds. This is my first attempt to review a ticket
however, and I stumbled upon 2 problems:

Is the documentation for these functions actually in the reference
manual? I wanted to check that the newly generated files looked good,
but could not find the place. Maybe I am just blind...

Typing sage.functions.log.Function_log? + TAB in the notebook (Linux
box with Firefox 3.6.3) the TESTS section (where some of the
documentation of the patch appear) is messed up. This also happens for
me without this patch, though.

@burcin
Copy link
Author

burcin commented Apr 11, 2010

Attachment: trac_8297-sfunction_extra_paranthesis.take2.patch.gz

apply only this patch

@burcin
Copy link
Author

burcin commented Apr 11, 2010

comment:3

The docstring was messed up because of the missing r before starting the string. attachment: trac_8297-sfunction_extra_paranthesis.take2.patch fixes this.

I don't know why the documentation for these functions don't show up in the reference manual. I suggest opening a new ticket for that.

@sagetrac-hgranath
Copy link
Mannequin

sagetrac-hgranath mannequin commented Apr 11, 2010

comment:4

Great, now sage.functions.log.Function_log? + TAB works well.

@sagetrac-hgranath
Copy link
Mannequin

sagetrac-hgranath mannequin commented Apr 11, 2010

Reviewer: Håkan Granath

@jhpalmieri
Copy link
Member

Merged: sage-4.4.alpha0

@jhpalmieri
Copy link
Member

comment:6

Merged "trac_8297-sfunction_extra_paranthesis.take2.patch" into 4.4.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants