Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ratpoints-2.1.3.p0 fails to build in Open Solaris x64 as 64 bit even if SAGE64=yes #8351

Closed
jaapspies opened this issue Feb 24, 2010 · 13 comments

Comments

@jaapspies
Copy link
Member

ratpoints builds in 32 bit mode on Solaris x64.

A patch is coming up.

Jaap

Component: porting

Author: Jaap Spies

Reviewer: David Kirkby

Merged: sage-4.4.4.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8351

@jaapspies
Copy link
Member Author

Author: Jaap Spies

@jaapspies
Copy link
Member Author

comment:1

Attachment: ratpoints-2.1.3.p1.patch.gz

A new spkg can be found here:

http://boxen.math.washington.edu/home/jsp/ports/ratpoints-2.1.3.p1.spkg

find_points.o:	ELF 64-bit LSB relocatable AMD64 Version 1
init.o:		ELF 64-bit LSB relocatable AMD64 Version 1
sift.o:		ELF 64-bit LSB relocatable AMD64 Version 1
sturm.o:	ELF 64-bit LSB relocatable AMD64 Version 1

Jaap

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Feb 24, 2010

comment:2

There is a problem with this patch, in that tests for CCFLAG64, not CFLAG64 as others do. So it needs work.

However, there are other problems with ratpoints that I am aware of. It is using the compiler option

-DUSE_SSE 

on SPARC, even though the SPARC processor has no SSE instructions. That does not appear to be a serious issue, but ratpoints has been implicated as the reason the Sage library does not build - see #7867, which is very serious.

It might be better if you leave this one to me to try to sort out, as the SPARC issues are more serious.

Dave

@jaapspies
Copy link
Member Author

comment:3

Replying to @sagetrac-drkirkby:

There is a problem with this patch, in that tests for CCFLAG64, not CFLAG64 as others do. So it needs work.

Ok, I can do that though CFLAG64 is not used in this spkg.

However, there are other problems with ratpoints that I am aware of. It is using the compiler option

-DUSE_SSE 

on SPARC, even though the SPARC processor has no SSE instructions. That does not appear to be a serious issue, but ratpoints has been implicated as the reason the Sage library does not build - see #7867, which is very serious.

It might be better if you leave this one to me to try to sort out, as the SPARC issues are more serious.

Yes, please solve the problems on SPARC, but that is certainly an other ticket.
Let this spkg work on Open Solaris x64 is the only issue solved with this ticket.

Cheers,

Jaap

Dave

@jaapspies
Copy link
Member Author

Attachment: ratpoints-2.1.3.p1+.patch.gz

@jaapspies
Copy link
Member Author

comment:4

New spkg with the same name:

http://boxen.math.washington.edu/home/jsp/ports/ratpoints-2.1.3.p1.spkg

Jaap

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Mar 3, 2010

comment:5

Sorry, I should have noted this earlier, but the package says

"Building with extra 64-bit flags for OS X and Open Solaris"

Whereas a more accurate description would be

"Building with the compiler flag(s) $CFLAG64 for a 64-bit build"

Hopefully this should work at the very least on Solaris 10, and hopefully other platforms such as Cygwin, perhaps HP-UX and/or AIX.

I would avoid mentioning Solaris specifically unless it is necessary. In this case it is not.

Dave

@jaapspies
Copy link
Member Author

comment:6

Replying to @sagetrac-drkirkby:

Sorry, I should have noted this earlier, but the package says

"Building with extra 64-bit flags for OS X and Open Solaris"

Whereas a more accurate description would be

"Building with the compiler flag(s) $CFLAG64 for a 64-bit build"

How important is this nit picking?

Hopefully this should work at the very least on Solaris 10, and hopefully other platforms such as Cygwin, perhaps HP-UX and/or AIX.

Solaris 10 64 bit? Since when is this an option?

I would avoid mentioning Solaris specifically unless it is necessary. In this case it is not.

Please go ahead and make a reviewers patch.

Jaap

Dave

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Mar 3, 2010

comment:7

Replying to @jaapspies:

Replying to @sagetrac-drkirkby:

Sorry, I should have noted this earlier, but the package says

"Building with extra 64-bit flags for OS X and Open Solaris"

Whereas a more accurate description would be

"Building with the compiler flag(s) $CFLAG64 for a 64-bit build"

How important is this nit picking?

I do not consider it nit-picking, for reasons you see below.

Hopefully this should work at the very least on Solaris 10, and hopefully other platforms such as Cygwin, perhaps HP-UX and/or AIX.

Solaris 10 64 bit? Since when is this an option?

It is very much a Sage goal. There is every reason to believe a Solaris 10 port will be 64-bit. The only reason the port was first 32-bit is that gcc tends to be less reliable on 64-bit SPARC.

It could even beat the Open Solaris port, though my interest is more in Open Solaris now.

Dave

@jaapspies
Copy link
Member Author

comment:8

Replying to @sagetrac-drkirkby:

Replying to @jaapspies:

Replying to @sagetrac-drkirkby:

Sorry, I should have noted this earlier, but the package says

"Building with extra 64-bit flags for OS X and Open Solaris"

Whereas a more accurate description would be

"Building with the compiler flag(s) $CFLAG64 for a 64-bit build"

How important is this nit picking?

I do not consider it nit-picking, for reasons you see below.

I don't see that.

Hopefully this should work at the very least on Solaris 10, and hopefully other platforms such as Cygwin, perhaps HP-UX and/or AIX.

Solaris 10 64 bit? Since when is this an option?

It is very much a Sage goal. There is every reason to believe a Solaris 10 port will be 64-bit. The only reason the port was first 32-bit is that gcc tends to be less reliable on 64-bit SPARC.

It could even beat the Open Solaris port, though my interest is more in Open Solaris now.

Please make it possible. My interest is in Open Solaris too. Let's make this
possible asap. If you insist on making this ticket the first in a target to make Solaris 10 64 bit work, please go ahead and count me off.

Jaap

Dave

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jun 4, 2010

comment:9

Lets just get this done. It works.

Dave

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jun 4, 2010

Reviewer: David Kirkby

@mwhansen
Copy link
Contributor

mwhansen commented Jun 6, 2010

Merged: sage-4.4.4.alpha0

@mwhansen mwhansen closed this as completed Jun 6, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants