Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot/plot3d/tri_plot.py is at 0% coverage: get it to 100% #8394

Closed
sagetrac-mhampton mannequin opened this issue Feb 28, 2010 · 10 comments
Closed

plot/plot3d/tri_plot.py is at 0% coverage: get it to 100% #8394

sagetrac-mhampton mannequin opened this issue Feb 28, 2010 · 10 comments

Comments

@sagetrac-mhampton
Copy link
Mannequin

sagetrac-mhampton mannequin commented Feb 28, 2010

The adaptive refinement code in tri_plot.py has almost no docstrings or tests. However, there are a lot of helpful comments in the code, and the file is not very long, so it should be pretty easy to bring this up to 100% coverage.

CC: @sagetrac-wcauchois @boothby

Component: graphics

Keywords: plotting

Author: Marshall Hampton

Reviewer: Minh Van Nguyen, Tom Boothby

Merged: sage-4.4.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/8394

@sagetrac-mhampton sagetrac-mhampton mannequin added this to the sage-4.4.1 milestone Feb 28, 2010
@sagetrac-mhampton
Copy link
Mannequin Author

sagetrac-mhampton mannequin commented Apr 25, 2010

adds basic doctests to tri_plot.py

@sagetrac-mhampton
Copy link
Mannequin Author

sagetrac-mhampton mannequin commented Apr 25, 2010

comment:1

Attachment: trac_8394_v1.patch.gz

@sagetrac-mhampton
Copy link
Mannequin Author

sagetrac-mhampton mannequin commented Apr 25, 2010

comment:2

The patch formally gets coverage of tri_plot.py from 0 to 100%. Since I still don't completely understand this module, the tests and descriptions could be better but this is an improvement.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Apr 28, 2010

Changed author from mhampton to Marshall Hampton

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Apr 28, 2010

Reviewer: Minh Van Nguyen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Apr 28, 2010

comment:3

Attachment: trac_8394-reviewer.patch.gz

The documentation is OK by me. I have just one trivial patch to add, which requires another pair of eyes other than mine. So if that reviewer patch gets a positive review, the whole ticket is good to go.

When the module plot/plot3d/tri_plot.py is added to the reference manual, building the reference manual with that newly added module would result in some warnings. But fixing that is another ticket.

@boothby
Copy link

boothby commented Apr 28, 2010

Changed reviewer from Minh Van Nguyen to Minh Van Nguyen, Tom Boothby

@boothby
Copy link

boothby commented Apr 28, 2010

comment:4

Looks great! Thank you!

@williamstein
Copy link
Contributor

Merged: 4.4.1.alpha2

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 3, 2010

Changed merged from 4.4.1.alpha2 to sage-4.4.1.alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants