Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prod(primes_first_n(64)).divisors() crashes #8573

Closed
sagetrac-asdjughewou9474388 mannequin opened this issue Mar 21, 2010 · 24 comments
Closed

prod(primes_first_n(64)).divisors() crashes #8573

sagetrac-asdjughewou9474388 mannequin opened this issue Mar 21, 2010 · 24 comments

Comments

@sagetrac-asdjughewou9474388
Copy link
Mannequin

sage: prod(primes_first_n(64)).divisors()
------------------------------------------------------------------------
Unhandled SIGSEGV: A segmentation fault occurred in Sage.
This probably occurred because a *compiled* component of Sage has a bug
in it and is not properly wrapped with sig_on(), sig_off().
Sage will now terminate.
------------------------------------------------------------------------

The crash is due to the fact that the number has exactly 2^64 divisors and this overflows a C integer.

Component: basic arithmetic

Keywords: integer divisors

Author: Jeroen Demeyer

Branch/Commit: 8c68d72

Reviewer: Ralf Stephan

Issue created by migration from https://trac.sagemath.org/ticket/8573

@sagetrac-asdjughewou9474388
Copy link
Mannequin Author

Changed keywords from product primes 190 to product primes 190 divisors

@mezzarobba
Copy link
Member

comment:2

It now (6.1) fails with a MemoryError, which looks reasonable to me.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Feb 3, 2014

Reviewer: Marc Mezzarobba, Jeroen Demeyer

@jdemeyer
Copy link

jdemeyer commented Feb 3, 2014

Changed reviewer from Marc Mezzarobba, Jeroen Demeyer to none

@jdemeyer jdemeyer changed the title prod(primes(190)).divisors() crashes prod(primes(311)).divisors() crashes Feb 3, 2014
@jdemeyer
Copy link

jdemeyer commented Feb 3, 2014

Changed keywords from product primes 190 divisors to integer divisors

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title prod(primes(311)).divisors() crashes prod(primes_first_n(64)).divisors() crashes Feb 3, 2014
@jdemeyer jdemeyer added this to the sage-6.2 milestone Feb 3, 2014
@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Feb 3, 2014

Branch: u/jdemeyer/ticket/8573

@jdemeyer
Copy link

jdemeyer commented Feb 5, 2014

Commit: 8c68d72

@jdemeyer
Copy link

jdemeyer commented Feb 5, 2014

New commits:

8c68d72Add overflow check to divisors()

@jdemeyer
Copy link

jdemeyer commented Feb 5, 2014

Author: Jeroen Demeyer

@rwst
Copy link

rwst commented Mar 10, 2014

Changed branch from u/jdemeyer/ticket/8573 to u/rws/ticket/8573

@rwst
Copy link

rwst commented Mar 10, 2014

comment:11

Rebased on 6.2.beta3. Tests OK --long in rings/. Seems to be an uncomplicated change.


New commits:

7e1f981Merge branch 'u/jdemeyer/ticket/8573' of git://trac.sagemath.org/sage into ticket/8573

@rwst
Copy link

rwst commented Mar 10, 2014

Changed commit from 8c68d72 to 7e1f981

@rwst
Copy link

rwst commented Mar 10, 2014

Reviewer: Ralf Stephan

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 12, 2014

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

42a405bMerge branch 'develop' (6.2.beta4) into ticket/8573

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 12, 2014

Changed commit from 7e1f981 to 42a405b

@jdemeyer
Copy link

Changed commit from 42a405b to 8c68d72

@jdemeyer
Copy link

comment:13

Why change the branch all the time?


New commits:

8c68d72Add overflow check to divisors()

@jdemeyer
Copy link

Changed branch from u/rws/ticket/8573 to u/jdemeyer/ticket/8573

@rwst
Copy link

rwst commented Mar 12, 2014

comment:14

Replying to @jdemeyer:

Why change the branch all the time?

https://groups.google.com/forum/#!topic/sage-devel/sTLT83d1g14

@jdemeyer
Copy link

comment:15

In this ticket, you made no changes, so there is no reason at all to commit/push anything. I'm not complaining about changing the branch, I am complaining about changing the branch without making any changes.

@vbraun
Copy link
Member

vbraun commented Mar 13, 2014

Changed branch from u/jdemeyer/ticket/8573 to 8c68d72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants