Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx should raise warning in case of ill formated enumerated lists #8575

Closed
hivert opened this issue Mar 22, 2010 · 10 comments
Closed

Sphinx should raise warning in case of ill formated enumerated lists #8575

hivert opened this issue Mar 22, 2010 · 10 comments

Comments

@hivert
Copy link

hivert commented Mar 22, 2010

In some cases, for example when an enumerated list is ill formated, in text mode ouput sphinx returns silently an empty string. It should at least raise some warning. See #8572 for an instance of the problem.
At this point, I don't know if it's a bug of sphinx or the way we call it.

Upstream: Completely fixed; Fix reported upstream

CC: @jhpalmieri @qed777

Component: documentation

Keywords: Sphinx, warning

Reviewer: Florent Hivert

Issue created by migration from https://trac.sagemath.org/ticket/8575

@hivert
Copy link
Author

hivert commented Mar 22, 2010

comment:2

There is a very good chance that this is a bug of sphinx. I asked it on
sphinx-dev. I'm waiting for their answer.

For the info, here is a ReST file that triggers the problem:

**************************
List Bug Triggering Module
**************************

    - list item 1 -- this item is correctly formated. So that there should be
      no problem with it..

    - list item 2 -- this item is ill formated. Sphinx should raise a warning
       when typesetting in in text mode.

Florent

@hivert
Copy link
Author

hivert commented Apr 6, 2010

comment:3

This is indeed a bug of sphinx (see this Sphinx-dev thread). Georg Brandl answered:

The behavior is clearly a bug, and I've now fixed it in changeset 93ae46825651
in the 0.6 branch. It will be part of the next bugfix release.

I'm not sure what to do now with this ticket... Should we back port the bugfix or wait for the next release ? Should this ticket be left open ?

Florent

@hivert
Copy link
Author

hivert commented Apr 6, 2010

Upstream: Fixed upstream, in a later stable release.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Apr 6, 2010

comment:4

Replying to @hivert:

I'm not sure what to do now with this ticket... Should we back port the bugfix or wait for the next release ? Should this ticket be left open ?

I would think wait for the next release, as that is (maybe) much easier than backporting. If you can backport, then by all means do so. Until the issue is fixed by upgrading to the new release with the bug fixed, or backporting, this ticket would remain open.

@hivert
Copy link
Author

hivert commented Apr 7, 2010

Work Issues: Sphinx release 0.6.6

@hivert
Copy link
Author

hivert commented Apr 7, 2010

comment:5

Replying to @sagetrac-mvngu:

I would think wait for the next release, as that is (maybe) much easier than backporting. If you can backport, then by all means do so. Until the issue is fixed by upgrading to the new release with the bug fixed, or backporting, this ticket would remain open.

According to Georg Brandl, Sphinx should make a new bugfix release "soon"... So I'm in favor of waiting for it.

@hivert
Copy link
Author

hivert commented Apr 4, 2011

Reviewer: Florent Hivert

@hivert
Copy link
Author

hivert commented Apr 4, 2011

comment:6

This ticket should be closed since sage uses now sphinx 1.0.4

(WARNING/2) Bullet list ends without a blank line; unexpected unindent.

I set this to positive review.

@hivert
Copy link
Author

hivert commented Apr 4, 2011

Changed upstream from Fixed upstream, in a later stable release. to Completely fixed; Fix reported upstream

@jdemeyer
Copy link

jdemeyer commented Apr 5, 2011

Changed work issues from Sphinx release 0.6.6 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants