Add galrep by Drew Sutherland to Sage

[williamstein]

The two data files go in SAGE_ROOT/data/extcode/galrep

Component: number fields

Author: William Stein, Drew Sutherland

Reviewer: Robert Miller

Issue created by migration from https://trac.sagemath.org/ticket/8617

[williamstein]

Attachment: trac_8617.patch.gz

[williamstein]

Attachment: galrep_ecdata.dat.gz

Attachment: galrep_gl2data.dat.gz

[ncalexan]

comment:2

This looks malformed -- there is no galrep.c code included in the patch (that I can see).

[rlmill]

comment:3

Attachment: trac_8617-part2.patch.gz

I will review this ticket, as long as someone else makes the necessary changes to the extcode spkg to include the galrep_*.dat files in the appropriate manner.

[rlmill]

Author: William Stein, Drew Sutherland

[rlmill]

Changed author from William Stein, Drew Sutherland to William Stein, Drew Sutherland, Robert Miller

[rlmill]

comment:5

Attachment: trac_8617-part3.patch.gz

PS - I don't think this is quite the right way to update extcode... I didn't realize I had done 'alpha0' --> 'alpha1'. I suppose the release manager would just add the "galrep" directory to the data/extcode directory, which would then be included in the new extcode spkg automatically by the dist script (Is this correct?)

[rlmill]

Changed author from William Stein, Drew Sutherland, Robert Miller to William Stein, Drew Sutherland

[rlmill]

comment:6

Since I'm doing release management for sage-4.5, I can just merge the files here the right way, and since I haven't actually contributed anything, I feel as if I can give it a positive review as is.

[rlmill]

Reviewer: Robert Miller

[rlmill]

Merged: sage-4.5.alpha4

[rlmill]

comment:10

I'm reverting this ticket, as it causes several weird problems: see #9445 and #9490.

[rlmill]

comment:11

Removed $SAGE_ROOT/data/extcode/galrep, as well as the relevant lines from module_list.py, sage/libs/all.py, setup.py and deleted sage/libs/galrep.

:-(

[rlmill]

Changed merged from sage-4.5.alpha4 to none

[williamstein]

comment:14

Note - I plan to include this in PSAGE: http://code.google.com/p/purplesage/issues/detail?id=10