Cusp forms constructor ignores the character and returns enormous space

[loefflerd]

sage: chi = DirichletGroup(109, CyclotomicField(3)).0
sage: CuspForms(chi, 2, base_ring = CyclotomicField(9))
Cuspidal subspace of dimension 442 of Modular Forms space of dimension 10, character [zeta3 + 1] and weight 2 over Cyclotomic Field of order 9 and degree6

facepalm

Component: modular forms

Author: David Loeffler

Reviewer: William Stein

Merged: sage-4.4.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8630

[loefflerd]

comment:2

*** wait, it's still wrong in certain nastly cases ***

[loefflerd]

Attachment: trac_8630.patch.gz

[williamstein]

comment:5

All doctests pass when this is applied against sage-4.3.5.

[williamstein]

comment:6

1. Below "ring" should be "modular symbols space":

 	117	    def change_ring(self, R): 
 	118	        r""" 
 	119	        Return this ring with the base ring changed to the ring R. 

2. Here I think the sentence should end with ::

 	419	    A more complicated example involving both a nontrivial character, and a 
 	420	    base field that is not minimal for that character: 

It's really awesome that you sphinxified a bunch of docs, in addition to fixing the bug in this ticket.

[loefflerd]

Attachment: trac_8630_docfixes.patch.gz

apply over previous patch

[loefflerd]

comment:7

Here's a tiny patch that corrects the two things you pointed out in the docstrings.

[loefflerd]

Reviewer: William Stein

[loefflerd]

Author: David Loeffler

[jhpalmieri]

comment:9

Merged in 4.4.alpha0:

• trac_8630.patch
• trac_8630_docfixes.patch

[jhpalmieri]

Merged: sage-4.4.alpha0