New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement scalar-valued Siegel modular forms on Sp(4,Z) #8701
Comments
comment:2
:-) |
This comment has been minimized.
This comment has been minimized.
comment:3
To clarify: I submitted this just before midnight Seattle time, so one could argue that it was before the deadline :) The patch applies cleanly to sage-4.3.5, and passes all but one test. The doctest coverage is 99%. The patch should also apply cleanly to earlier versions of Sage, but depending of how far back you go the tests might not pass any more. I checked with sage-4.3.3 and it was fine. Since this patch includes the patches at trac #8602 and #8681, it will fail to apply when those tickets get reviewed positively and merged. In fact, #8602 just got merged into sage-4.4.alpha0, so I will eventually rebase the Siegel patch on top of that. I believe that the objective of this first submission is to have something that works perfectly in the case of scalar-valued forms on
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:5
I am replacing the patch with one that has fixes for a couple of issues on the list (and I'm updating the list to reflect this). |
Attachment: siegel_combined.patch.gz applies to sage-4.4.3 and sage-4.4.4.alpha0 |
comment:6
Since a few more prerequisites went into Sage, I had to rebase the patch so it applies to 4.4.3 and 4.4.4.alpha0. |
This comment has been minimized.
This comment has been minimized.
comment:8
I am worried that the groups on which the forms are defined are specified by strings ('Gamma0(5)') and not on python objects. |
comment:9
FYI, the patch is now in psage: http://code.google.com/p/purplesage/source/detail?r=508752edecf0b1f41373e5761a74b61c79024c50 |
Attachment: trac_8701_siegel_modular_form_documentation.patch.gz Addresses many of the comments from before. I need still need to add copyright information, include more examples at the top of siegel_modular_forms.py, and deal with the functor stuff. |
Addresses ncalexander's concern about the way the groups are defined |
Attachment: siegel_modular_group.patch.gz Attachment: hecke_operators_bad_primes_exception.patch.gz Raises an exception when trying to find the image of a form F under the Hecke operator T(p) when p divides the level of F |
Fix an issue with sage 4.6.2 |
Attachment: fix-siegel.gz Attachment: fix-coeffs-in-ring.gz Have the constructor coerce the coefficients into the ring they're supposed to be |
Attachment: trac_8701_siegel_rebased.patch.gz |
comment:14
For the bot: apply only trac_8701_siegel_folded_v1.patch The folded patch trac_8701_siegel_folded_v1.patch can now be used as a new starting point. |
This comment has been minimized.
This comment has been minimized.
comment:15
apply only trac_8701_siegel_folded_v1.patch |
comment:16
Attachment: trac_8701_siegel_folded_v1.patch.gz apply only trac_8701_siegel_folded_v1.patch |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed author from Nils-Peter Skoruppa, Nathan Ryan, Martin Raum, Gonzalo Tornaria, Craig Citro, Alex Ghitza to Nils-Peter Skoruppa, Nathan Ryan, Martin Raum, Gonzalo Tornaría, Craig Citro, Alex Ghitza |
At Sage Days 20.25 in Montreal, we have decided to submit an initial version of the Siegel modular forms code by Friday 16 April 2010.
It's now a few minutes before midnight, and lest I turn into a pumpkin, I am uploading a patch with what we have so far.
I'm marking it as "needs work" since there are still a number of issues to be resolved. I'll list these in the comments soon.
To clarify: I submitted this just before midnight Seattle time, so one could argue that it was before the deadline :)
The patch applies cleanly to sage-4.4.3 and sage-4.4.4.alpha0, and passes all tests. The doctest coverage is 98.8% (81 out of 82 functions). The patch will not work with earlier versions of Sage since it depends on patches at #8602 and #8681 which have now been merged.
I believe that the objective of this first submission is to have something that works perfectly in the case of scalar-valued forms on
Sp(4,Z)
. Here are the issues that I am aware of and are still blocking this:siegel_modular_form.py
that explains in detail how the code is meant to be used, what the interesting features are, etc. We also need to explain how precisions work (either in the main file or insiegel_modular_form_prec.py
weights='all'
breaks at the fifth generatordegree
in_siegel_modular_forms_generators
should be properly documented, and there should be a doctest for it (I don't like the name "degree" BTW, because it already has a meaning for Siegel modular forms)default_prec
inSiegelModularFormsAlgebra
should be documentedIf you want to add to or modify these, please feel free to do this by editing the description on this ticket.
CC: @sagetrac-NilsSkoruppa @sagetrac-mraum @tornaria @williamstein @novoselt @ncalexan @mstreng
Component: modular forms
Keywords: siegel modular forms
Author: Nils-Peter Skoruppa, Nathan Ryan, Martin Raum, Gonzalo Tornaría, Craig Citro, Alex Ghitza
Branch/Commit: u/chapoton/8701 @
4e4f04d
Issue created by migration from https://trac.sagemath.org/ticket/8701
The text was updated successfully, but these errors were encountered: