Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the _repr_ of IntegerRange #8704

Closed
hivert opened this issue Apr 17, 2010 · 8 comments
Closed

Improve the _repr_ of IntegerRange #8704

hivert opened this issue Apr 17, 2010 · 8 comments

Comments

@hivert
Copy link

hivert commented Apr 17, 2010

The actual printing was discussed on this thread of sage-combinat-devel.

I also took the chance of normalizing the input to improve equality.

Component: combinatorics

Keywords: integer range

Author: Florent Hivert

Reviewer: Mike Hansen

Merged: sage-4.4.4.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8704

@hivert hivert self-assigned this Apr 17, 2010
@hivert

This comment has been minimized.

@hivert
Copy link
Author

hivert commented May 13, 2010

Changed keywords from none to integer range

@hivert hivert added this to the sage-4.4.2 milestone May 13, 2010
@hivert
Copy link
Author

hivert commented May 15, 2010

comment:2

I fixed a doctest failure... All tests should pass now.

@hivert
Copy link
Author

hivert commented May 31, 2010

comment:3

I fixed the following issues raised by Nicolas on sage-combinat-devel

> >> The output of IntegerRange is much nicer now. I was about to put a
> >> positive review, when I had a last doubt about the consistency between:
> >>
> >>      sage: I = IntegerRange(2,100,5); I
> >>      {2, 7 .. 97}
> >>      sage: I = IntegerRange(54,Infinity,3); I
> >>      {54, 57, ..}
> >>
> >> Should there be a comma in both cases, in none, or is it good as is?
> >
> > I would say {2, 7 .. 97} should be replaced by {2, 7, .., 97} for
> > consistency.

@hivert
Copy link
Author

hivert commented May 31, 2010

Attachment: trac_8704-integer_range_print-fh.patch.gz

@mwhansen
Copy link
Contributor

mwhansen commented Jun 6, 2010

Reviewer: Mike Hansen

@mwhansen
Copy link
Contributor

mwhansen commented Jun 6, 2010

comment:4

Looks good to me.

@mwhansen
Copy link
Contributor

mwhansen commented Jun 6, 2010

Merged: sage-4.4.4.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants