Bug in computing radical of univariate polynomial

[sagetrac-johanbosman]

From #sage-devel:

^ sage: R. = GF(2)[]
sage: (x!^2).radical()
1^

Component: algebra

Author: Johan Bosman

Reviewer: Leif Leonhardy, Andrey Novoseltsev

Merged: sage-4.4.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/8736

[nexttime]

comment:3

I was told it is not bad to put the corresponding ticket number in the doctest and/or near the code that fixes an issue for later reference.

[sagetrac-johanbosman]

Attachment: trac_8736_radical_fix.patch.gz

[sagetrac-johanbosman]

comment:4

Like this? ;)

[novoselt]

comment:5

Probably like that, but now this patch file contains two patches and does not apply cleanly. I know that if you remove the existing patch before repeating the export command, everything should be fine and you will get a nice new patch. Maybe there are better ways which I am not aware of. Otherwise the patch seems fine to me and passes all doctests (I ran them on the previous working version).

[novoselt]

Work Issues: patch does not apply

[nexttime]

Johan's patch with first hunk deleted

[nexttime]

comment:6

Attachment: trac_8736_radical_fix_single_patch.patch.gz

It's easier to just edit the patch (i.e., delete the first hunk)...

[nexttime]

Changed work issues from patch does not apply to none

[novoselt]

Reviewer: Leif Leonhardy, Andrey Novoseltsev

[williamstein]

Merged: 4.4.1.alpha2

[sagetrac-mvngu]

Changed merged from 4.4.1.alpha2 to sage-4.4.1.alpha2