New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gap-4.4.12.p0 is full of *CRAP* #8774
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
|
comment:3
I'll make a new spkg later today. |
comment:4
Replying to @dimpase:
new spkg is here: http://boxen.math.washington.edu/home/dima/packages/gap-4.4.12.p2.spkg All I did is removing everything in src/bin/ and removing src/GAP\ 4\ PPC (apart from updating SPKG.txt etc) Tested on Debian Linux x86_64 (just in case, as it shouldn't be anything problematic...) |
comment:5
should be very easy to review! |
comment:6
The package isn't perfect yet, but these changes are definitely good. Positive review. By the way, I'm creating a p3 for ticket #8773 at the moment, starting from this p2. It will fix some strict aliasing problems with gcc 4.5.0, and will also fix the pre-applied patch to saveload.c. |
comment:7
(The p3 mentioned in my previous comment now needs review at #8773) |
Merged: 4.4.1.alpha0 |
Author: Dmitrii Pasechnik |
Reviewer: Willem Jan Palenstijn |
Changed merged from 4.4.1.alpha0 to sage-4.4.1.alpha0 |
While gap-4.4.12.p0 was unpacking, I noticed:
NO!!! We absolutely should not be shipping Windows frickin' binaries with Sage. Ticket #8076 introduced all these.
NOTE: It is my (=William's) fault that 8076 got a positive review.
CC: @wdjoyner
Component: packages: standard
Author: Dmitrii Pasechnik
Reviewer: Willem Jan Palenstijn
Merged: sage-4.4.1.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/8774
The text was updated successfully, but these errors were encountered: