New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sagenb-0.8.p1.spkg: broken dependencies, requires internet conn. to build #8861
Comments
This comment has been minimized.
This comment has been minimized.
comment:1
(corrected numbering of the package cited) |
comment:2
I just couldn't resist and did exactly that, the spkg is here: http://sage.math.washington.edu/home/weberg/spkg/sagenb-0.8.p2.spkg I note this still as "needs work" for three reasons: The sagenb spkg inexplicably misses the required hg repository (to able to monitor changes in spkg-install for example). In the file SPKG.txt, adding a note about testing on a computer without internet connection seems appropriate. |
comment:3
Thanks for the quick work! Replying to @sagetrac-GeorgSWeber:
The sagenb spkg is automatically generated by src/sagenb/spkg-dist, therefore the hg repository is actually in src/sagenb.
Done. I've posted the version with the changes in the hg repo here: http://sage.math.washington.edu/home/timdumol/sagenb-0.8.p2.spkg |
comment:4
I goofed it. I r-eadded "mechanize.0.1.11.zip", and in the file spkg-install, changed the version number in the corresponding line. But then, the line 6 reads "easy_install mechanize-0.1.11.tar.gz". Since there is now ...tar.gz, but "only" a ...zip, the install blows up exactly as before, if there is not internet connection. I changed the line to end with ...zip instead, and everything went fine (on a MacIntel with OS X 10.4.11), even all doctests pass! But since that computer has no internet connection, I wasn't able to upload that yet. Tim, your version of the spkg also still suffers from this flaw, so I fear this ticket is back to "needs_work" again. |
comment:5
I checked the spkg I posted, and I don't see any problem.
|
comment:6
And the contents of spkg-install:
|
comment:7
A trivial point. When uncompressed, Tim's updated spkg has this name: [mvngu@sage sagenb]$ ls
sagenb-0.7.2.spkg sagenb-0.7.5.1.spkg sagenb-0.7.5.2.spkg sagenb-0.8.p2.spkg
[mvngu@sage sagenb]$ tar -jxf sagenb-0.8.p2.spkg
[mvngu@sage sagenb]$ ls
sagenb-0.7.2.spkg sagenb-0.7.5.2.spkg sagenb-0.8.p2.spkg
sagenb-0.7.5.1.spkg sagenb-0.8 Notice the directory name http://sage.math.washington.edu/home/mvngu/spkg/standard/sagenb/sagenb-0.8.p2.spkg This is essentially Tim's spkg, but I changed the name as per above instructions, prior to tar gzip2 compressing the updated spkg. |
Reviewer: Minh Van Nguyen |
This comment has been minimized.
This comment has been minimized.
comment:8
Tim, Minh, you both are right, of course! |
Changed reviewer from Minh Van Nguyen to Minh Van Nguyen, Georg S. Weber |
comment:9
OK, using the (slightly altered) version that Minh posted from Tim's p2 spkg, I found out the following:
I now understand the sagenb spkg better, i.e. that the file "spkg-install" is being generated, and that the dependencies under src/ are being downloaded during a standard generation of some new version of this spkg. So the discrepancy that crept in my goofed attempt just cannot occur this way. What I disliked, is that this did lead also to the following updates of certain dependencies in between sagenb-0.8.p1.spkg and sagenb-0.8.p2.spkg:
Personally, in the light of my other findings and tests above, I do not consider this as critical, assuming that sagenb does not use any "bleeding edge" functionality of the above four zope packages, that would be affected by these updates. If somebody thinks I'm wrong here, then please feel free to switch the status back to "needs_work". |
Author: Tim Dumol |
comment:10
Zope very rarely makes backward incompatible changes to its API (afaik), so I think it's reasonably safe to update automatically. Any problems will be spotted during testing, anyways. Otherwise, we can change the dependencies to '==' instead of '>='. |
Merged: sage-4.4.2.alpha0 |
This was first noted by John Cremona.
On a computer that is not connected to the internet, the build fails:
On a computer with internet connection, one finds in the install.log:
So the solution seems to be pretty easy:
Make a new sagenb-0.8.p2.spkg, by throwing out "mechanize-0.2.0.tar.gz" under /src/, adding back the old "mechanize-0.1.11.zip", and finally adjusting the corresponding line 6 in the spkg-install file.
Apply this spkg:
CC: @williamstein @TimDumol
Component: build
Author: Tim Dumol
Reviewer: Minh Van Nguyen, Georg S. Weber
Merged: sage-4.4.2.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/8861
The text was updated successfully, but these errors were encountered: