Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial on Python object and classes #8886

Closed
sagetrac-mvngu mannequin opened this issue May 5, 2010 · 28 comments
Closed

tutorial on Python object and classes #8886

sagetrac-mvngu mannequin opened this issue May 5, 2010 · 28 comments

Comments

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 5, 2010

As the subject says. See this sage-devel thread for some background information. This should be coordinated with #8470.

Apply:

  1. attachment: trac_8886-objects-classes_tutorial-fh-jhp-rebased.patch

Depends on #11251
Depends on #11632

CC: @nexttime @nthiery

Component: documentation

Author: Florent Hivert, Minh Van Nguyen

Reviewer: John Palmieri

Merged: sage-4.7.2.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/8886

@sagetrac-mvngu sagetrac-mvngu mannequin added this to the sage-4.7.1 milestone May 5, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin self-assigned this May 5, 2010
@hivert
Copy link

hivert commented May 5, 2010

comment:1

I'm preparing a patch on sage-combinat queue... I took ownership of the ticket (to have it in the my ticket report).

Florent

@hivert hivert assigned hivert and unassigned sagetrac-mvngu May 5, 2010
@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented May 5, 2010

Attachment: trac_8886-config.patch.gz

@sagetrac-mvngu

This comment has been minimized.

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented May 5, 2010

Author: Minh Van Nguyen

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented May 5, 2010

comment:2

The patch trac_8886-config.patch contains the Sphinx configuration and build files. Such files are required to get Sphinx to build documents in the category "Thematic Tutorials". When #8468 was merged, the prerequisites listed on that ticket were not merged at all. This meant that the relevant build and configuration files did not go into Sage 4.4.1. The patch trac_8886-config.patch is an attempt to fix this. You should apply this patch prior to adding any new documents to "Thematic Tutorials".

@sagetrac-mjordan7
Copy link
Mannequin

sagetrac-mjordan7 mannequin commented May 5, 2010

comment:3

I have sage 4.3.5 and have been manually applying the doc patches. This one does not apply even though I have the prereqs. I have applied 8464, 8465, 8469, and 8442. Is that the wrong order?
~Mark

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented May 5, 2010

comment:4

Replying to @sagetrac-mjordan7:

I have sage 4.3.5 and have been manually applying the doc patches. This one does not apply even though I have the prereqs.

I didn't mention that you need to apply patches on top of Sage 4.4.1. The patches on this ticket and the prequisite ticket were produced on top of Sage 4.4.1. Sorry for the inconvenience.

@sagetrac-mvngu

This comment has been minimized.

@jhpalmieri
Copy link
Member

comment:6

If #8465 is merged, then trac_8886-config.patch is no longer needed.

@hivert

This comment has been minimized.

@hivert
Copy link

hivert commented Jun 28, 2011

Dependencies: 11251

@hivert
Copy link

hivert commented Jun 28, 2011

Changed author from Minh Van Nguyen to Florent Hivert, Minh Van Nguyen

@hivert
Copy link

hivert commented Jun 28, 2011

@hivert

This comment has been minimized.

@jhpalmieri
Copy link
Member

comment:9

There is a mistake in thematic_tutorials/conf.py which prevents math like \QQ from being rendered properly. This is fixed in #11632, so I've made that a dependency for this ticket. (Please review it!)

I've fixed some typos and grammatical errors. See the "delta" patch for the differences between my patch and the previous one. I'm happy with what you've done, so if you're happy with my changes, give the ticket a positive review.

@jhpalmieri

This comment has been minimized.

@jhpalmieri
Copy link
Member

Changed dependencies from 11251 to #11251, #11632

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

Attachment: trac_8886-delta.patch.gz

@hivert
Copy link

hivert commented Jul 28, 2011

comment:10

Attachment: trac_8886-objects-classes_tutorial-jhp.patch.gz

Replying to @jhpalmieri:

There is a mistake in thematic_tutorials/conf.py which prevents math like
\QQ from being rendered properly. This is fixed in #11632, so I've made
that a dependency for this ticket. (Please review it!)

I'll do it.

I've fixed some typos and grammatical errors. See the "delta" patch for the
differences between my patch and the previous one. I'm happy with what
you've done, so if you're happy with my changes, give the ticket a positive
review.

Thanks for correcting my bad English. I'm mostly happy with your change. The
only remark I have is the removal of the link
:ref:`tutorial-programming-python`. It is an up coming tutorial which is
not yet fully finished. I'm creating a new ticket (#11633) and reinstating the pointer
there.

Thanks for your careful review.

Florent

@jdemeyer jdemeyer removed this from the sage-4.7.1 milestone Jul 28, 2011
@hivert
Copy link

hivert commented Aug 31, 2011

comment:13

Nicolas pointed out the following typo:

line 14:

functions (see the "Programming" section of the Sage tutorial) -- but now further +knowledge

"now" should be "no". I'm updating a corrected patch.

@hivert
Copy link

hivert commented Aug 31, 2011

@hivert
Copy link

hivert commented Aug 31, 2011

comment:14

New new patch is updated it should be reviewed. The diff from the preceding patch is:

1.1 --- a/trac_8886-objects-classes_tutorial-fh-jhp.patch Wed Aug 31 09:50:46 2011 +0200 
1.2 +++ b/trac_8886-objects-classes_tutorial-fh-jhp.patch Wed Aug 31 11:37:04 2011 +0200 
1.3 @@ -890,7 +890,7 @@ 
1.4 +This tutorial is an introduction to object-oriented programming in Python and 
1.5 +Sage. It requires basic knowledge about imperative/procedural programming (the 
1.6 +most common programming style) -- that is, conditional instructions, loops, 
1.7 -+functions (see the "Programming" section of the Sage tutorial) -- but now further knowledge 
1.8 ++functions (see the "Programming" section of the Sage tutorial) -- but no further knowledge 
1.9 +about objects and classes is assumed. It is designed as an alternating 
1.10 +sequence of formal introduction and exercises. :ref:`solutions` are given at 
1.11 +the end. 

@hivert

This comment has been minimized.

@nthiery
Copy link
Contributor

nthiery commented Aug 31, 2011

comment:15

Replying to @hivert:

New new patch is updated it should be reviewed. The diff from the preceding patch is:

1.1 --- a/trac_8886-objects-classes_tutorial-fh-jhp.patch Wed Aug 31 09:50:46 2011 +0200 
1.2 +++ b/trac_8886-objects-classes_tutorial-fh-jhp.patch Wed Aug 31 11:37:04 2011 +0200 
1.3 @@ -890,7 +890,7 @@ 
1.4 +This tutorial is an introduction to object-oriented programming in Python and 
1.5 +Sage. It requires basic knowledge about imperative/procedural programming (the 
1.6 +most common programming style) -- that is, conditional instructions, loops, 
1.7 -+functions (see the "Programming" section of the Sage tutorial) -- but now further knowledge 
1.8 ++functions (see the "Programming" section of the Sage tutorial) -- but no further knowledge 
1.9 +about objects and classes is assumed. It is designed as an alternating 
1.10 +sequence of formal introduction and exercises. :ref:`solutions` are given at 
1.11 +the end. 

I suggested that tiny change, so positive review on it :-)

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Oct 6, 2011

comment:16

Attachment: trac_8886-objects-classes_tutorial-fh-jhp-rebased.patch.gz

@jdemeyer jdemeyer added this to the sage-4.7.2 milestone Oct 6, 2011
@jdemeyer jdemeyer removed the pending label Oct 6, 2011
@jdemeyer
Copy link

jdemeyer commented Oct 8, 2011

Merged: sage-4.7.2.alpha4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants