Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsets element construction is broken #8902

Closed
hivert opened this issue May 6, 2010 · 7 comments
Closed

Subsets element construction is broken #8902

hivert opened this issue May 6, 2010 · 7 comments

Comments

@hivert
Copy link

hivert commented May 6, 2010

sage: S2 = Subsets(2)
sage: S2([])
<type 'sage.structure.parent.Set_generic'>
sage: S2([1])
<type 'sage.structure.parent.Set_generic'>

The attached patch fixes this.

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: Subsets constructor

Author: Florent Hivert

Reviewer: Nicolas M. Thiéry

Merged: sage-4.4.4.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8902

@hivert
Copy link
Author

hivert commented May 12, 2010

comment:1

Note: This is a temporary fixes before the cleanup of combinat (categorification of the combinatorial classes is done).

@hivert
Copy link
Author

hivert commented May 12, 2010

Author: Florent Hivert

@hivert
Copy link
Author

hivert commented May 31, 2010

Attachment: trac_8902-subsets_call_fix-fh.patch.gz

@hivert
Copy link
Author

hivert commented May 31, 2010

Reviewer: Nicolas M. Thiéry

@hivert
Copy link
Author

hivert commented May 31, 2010

comment:3

Nicolas on sage-combinat series file:

trac_8902-subsets_call_fix-fh.patch               # Positive review, assuming tests pass (NT)

I got a all test passes on massena.

Note: the category related problem we discussed on the phone is postponed until #8910 in the patch trac_8910-subsets_an_element-fh.patch.

If you are ok with that can you put a positive review ?

@nthiery

This comment has been minimized.

@mwhansen
Copy link
Contributor

mwhansen commented Jun 5, 2010

Merged: sage-4.4.4.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants