Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate EnumeratedSet #8930

Closed
hivert opened this issue May 8, 2010 · 7 comments
Closed

Deprecate EnumeratedSet #8930

hivert opened this issue May 8, 2010 · 7 comments
Assignees
@hivert
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-4.4.4

Comments

@hivert
Copy link

hivert commented May 8, 2010

EnumeratedSet is not used, redundant with Set and confusing with EnumeratedSets(). The attached patch deprecates it.

Component: combinatorics

Keywords: EnumeratedSet, deprecate

Author: Florent Hivert

Reviewer: Nicolas M. Thiéry

Merged: sage-4.4.4.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8930
@hivert hivert added this to the sage-4.4.4 milestone May 8, 2010
@hivert hivert self-assigned this May 8, 2010
@hivert
Copy link
Author

hivert commented May 8, 2010

Author: Florent Hivert

@hivert
Copy link
Author

hivert commented May 12, 2010

comment:2

There was a failing doctest and I also discovered some typos in the doc of the Category EnumeratedSets (missing s)... I reupload a new patch.

@hivert
Copy link
Author

hivert commented May 31, 2010

comment:3

From Nicolas on combinat-series file:

trac_8930-enumerated_set_deprecate-fh.patch       # Positive review, assuming tests pass (NT)

I got a all test pass on massena. I'll just reupload from the queue, can you put a positive review ?

@hivert
Copy link
Author

hivert commented May 31, 2010

Reviewer: Nicolas M. Thiéry

@nthiery

This comment has been minimized.

Sign in to view
@nthiery
Copy link
Contributor

nthiery commented May 31, 2010

comment:4

Attachment: trac_8930-enumerated_set_deprecate-fh.patch.gz

Simple patch; does what it claims, and what it claims is good; pass tests; positive review!

@mwhansen
Copy link
Contributor

mwhansen commented Jun 5, 2010

Merged: sage-4.4.4.alpha0

@mwhansen mwhansen closed this as completed Jun 5, 2010
@nathanncohen nathanncohen mannequin mentioned this issue Jan 14, 2023
Closed
@a-andre a-andre mentioned this issue May 13, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hivert hivert

Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.4.4
Development

No branches or pull requests
3 participants
@mwhansen @nthiery @hivert