Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conversion of integer mods to Gap #8970

Closed
loefflerd mannequin opened this issue May 14, 2010 · 6 comments
Closed

conversion of integer mods to Gap #8970

loefflerd mannequin opened this issue May 14, 2010 · 6 comments
Assignees
@aghitza
Labels
c: algebra p: major / 3 t: bug
Milestone
sage-4.5.2

Comments

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented May 14, 2010

The code to convert elements of integer mod rings into Gap elements is needlessly complicated, and also very broken when the modulus isn't prime.

Component: algebra

Author: David Loeffler

Reviewer: Robert Miller

Merged: sage-4.5.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8970
@loefflerd loefflerd mannequin added this to the sage-4.5.2 milestone May 14, 2010
@loefflerd loefflerd mannequin added c: algebra labels May 14, 2010
@loefflerd loefflerd mannequin assigned aghitza May 14, 2010
@loefflerd
Copy link
Mannequin Author

loefflerd mannequin commented May 15, 2010

Attachment: trac_8970-gap_integer_mod.patch.gz

patch against 4.4.1

@loefflerd
Copy link
Mannequin Author

loefflerd mannequin commented May 15, 2010

comment:1

Here's a patch, which takes care of conversion in both directions.

@loefflerd loefflerd mannequin added the s: needs review label May 15, 2010
@rlmill
Copy link
Mannequin

rlmill mannequin commented Jun 22, 2010

Author: David Loeffler

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jun 22, 2010

comment:2

Looks good to me.

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jun 22, 2010

Reviewer: Robert Miller

@qed777
Copy link
Mannequin

qed777 mannequin commented Jul 20, 2010

Merged: sage-4.5.2.alpha0

@qed777 qed777 mannequin removed the s: positive review label Jul 20, 2010
@qed777 qed777 mannequin closed this as completed Jul 20, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghitza aghitza

Labels
c: algebra p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.5.2
Development

No branches or pull requests
1 participant
@aghitza