Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust developer walkthrough for two changes to mercurial queues syntax #8991

Closed
rbeezer mannequin opened this issue May 19, 2010 · 7 comments
Closed

Adjust developer walkthrough for two changes to mercurial queues syntax #8991

rbeezer mannequin opened this issue May 19, 2010 · 7 comments

Comments

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented May 19, 2010

hg qinit
hg -f qnew

are deprecated in newer versions of Mercurial (1.5) which some may be using (ie not using the version distributed with Sage). This patch includes text to transition to the new state of the syntax without abandoning the old.

CC: @sagetrac-alubovsky

Component: documentation

Author: Rob Beezer

Reviewer: Arthur Lubovsky

Merged: sage-4.4.2.final

Issue created by migration from https://trac.sagemath.org/ticket/8991

@rbeezer rbeezer mannequin added c: documentation labels May 19, 2010
@rbeezer rbeezer mannequin assigned sagetrac-mvngu May 19, 2010
@sagetrac-alubovsky
Copy link
Mannequin

sagetrac-alubovsky mannequin commented May 19, 2010

comment:1

Attachment: trac_8991-mq-syntax-for-developers.patch.gz

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented May 19, 2010

comment:3

alubovsky -

Thanks for the quick review. Probably best to give the release manager (who makes the final decision about adding this into "official" Sage) some idea of what testing you did. Such as something about building the developers manual without warnings, output looks fine, mq changes are accurately reported, etc.

Also, please put your real name into the "Reviewer" field and you'll get credit in the release tour and the Trac reports. ;-)

cc me when you submit that patch of typos you are collecting!

Rob

@sagetrac-alubovsky
Copy link
Mannequin

sagetrac-alubovsky mannequin commented May 19, 2010

comment:4

Patch output looks fine, no warnings building with
sage -docbuild developer html

patch applied just fine, (not sure what mq changes are accurately reported means.)

@sagetrac-alubovsky
Copy link
Mannequin

sagetrac-alubovsky mannequin commented May 19, 2010

Reviewer: Arthur Lubovsky

@sagetrac-alubovsky
Copy link
Mannequin

sagetrac-alubovsky mannequin commented May 19, 2010

comment:5

I should add, i applied the patch to the latest version of sage-combinat repository, instead of sage-main, hopefully it makes no difference.

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented May 19, 2010

comment:6

Replying to @sagetrac-alubovsky:

(not sure what mq changes are accurately reported means.)

I was just suggesting you might note the content of the changes was correct. I don't have Mercurial 1.5 installed anywhere, so was working off documantation I could find online (which wsn't always helpful).

In this case, I think the sage-combinat repo is probably OK.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 19, 2010

Merged: sage-4.4.2.final

@sagetrac-mvngu sagetrac-mvngu mannequin added this to the sage-4.4.2 milestone May 19, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed May 19, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants