New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust developer walkthrough for two changes to mercurial queues syntax #8991
Comments
comment:1
Attachment: trac_8991-mq-syntax-for-developers.patch.gz |
comment:3
alubovsky - Thanks for the quick review. Probably best to give the release manager (who makes the final decision about adding this into "official" Sage) some idea of what testing you did. Such as something about building the developers manual without warnings, output looks fine, mq changes are accurately reported, etc. Also, please put your real name into the "Reviewer" field and you'll get credit in the release tour and the Trac reports. ;-) cc me when you submit that patch of typos you are collecting! Rob |
comment:4
Patch output looks fine, no warnings building with patch applied just fine, (not sure what mq changes are accurately reported means.) |
Reviewer: Arthur Lubovsky |
comment:5
I should add, i applied the patch to the latest version of sage-combinat repository, instead of sage-main, hopefully it makes no difference. |
comment:6
Replying to @sagetrac-alubovsky:
I was just suggesting you might note the content of the changes was correct. I don't have Mercurial 1.5 installed anywhere, so was working off documantation I could find online (which wsn't always helpful). In this case, I think the sage-combinat repo is probably OK. |
Merged: sage-4.4.2.final |
are deprecated in newer versions of Mercurial (1.5) which some may be using (ie not using the version distributed with Sage). This patch includes text to transition to the new state of the syntax without abandoning the old.
CC: @sagetrac-alubovsky
Component: documentation
Author: Rob Beezer
Reviewer: Arthur Lubovsky
Merged: sage-4.4.2.final
Issue created by migration from https://trac.sagemath.org/ticket/8991
The text was updated successfully, but these errors were encountered: