Fast cython class for maps between finite sets.

[hivert]

The patch implements fast Cython classes for maps between finite sets. The goal in particular is to allow for building easily submonoids of the monoid of all maps from one set to itself.

See for example class NDPFMonoidPosetNewSet in
parking_functions_posets-fh.patch

Apply:

1. attachment: trac_9109-finite_set_maps-fh.patch

Dependencies: #8702

Component: combinatorics

Keywords: finite sets map

Author: Florent Hivert

Reviewer: Mike Hansen, Nicolas M. Thiéry

Merged: sage-4.7.alpha5

Issue created by migration from https://trac.sagemath.org/ticket/9109

[hivert]

comment:4

I just uploaded a new version after some changes in #8702

[hivert]

Attachment: trac_9109-finite_set_maps-fh.2.patch.gz

[hivert]

Reviewer: Mike Hansen, Nicolas M. Thiéry

[hivert]

comment:5

This should now be ready for review

[hivert]

comment:6

They are still a few glitches remaining. Setting status back to need work

[hivert]

comment:8

The submitted patch should fix all remaining problem. Please review.

[nthiery]

comment:9

We discussed the design quite some with Florent, and used the code intensively over the last month. It's a useful addition! Thanks!

Florent: please check the small reviewer patch on the Sage-Combinat queue. If the changes are ok with you, you can fold/upload and set a positive review on my behalf.

[hivert]

comment:10

Florent: please check the small reviewer patch on the Sage-Combinat
queue. If the changes are ok with you, you can fold/upload and set a
positive review on my behalf.

Hi Nicolas ! Thanks a lot for the numerous English corrections. The doc is
much better now ! I'm perfectly ok with all your changes, except for the
following wrong ReST markup:

diff --git a/sage/sets/finite_set_map_cy.pyx b/sage/sets/finite_set_map_cy.pyx
--- a/sage/sets/finite_set_map_cy.pyx
+++ b/sage/sets/finite_set_map_cy.pyx
@@ -86,7 +86,7 @@ cpdef fibers(f, domain):
         {1: {1}}
 
     .. seealso:: :func:`fibers_args` if one needs to pass extra
-    arguments to ``f``.
+       arguments to ``f``.
     """
     result = {}
     for x in domain:

I folded your patch and added this small change. It is a rather trivial change
but, in order to follow the rules, someone has to look at it. So it's now your
job to set the positive review :-)

[nthiery]

comment:11

Attachment: trac_9109-finite_set_maps-fh.patch.gz

[jdemeyer]

Merged: sage-4.7.alpha5