Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G.list() can be modified #9155

Closed
robertwb opened this issue Jun 6, 2010 · 9 comments
Closed

G.list() can be modified #9155

robertwb opened this issue Jun 6, 2010 · 9 comments
Assignees
@aghitza
Labels
c: group theory p: trivial / 5 t: enhancement
Milestone
sage-7.2

Comments

@robertwb
Copy link
Contributor

robertwb commented Jun 6, 2010

cached_method should not be used with mutable return values

sage: G = SymmetricGroup(2)
sage: elements = G.list()
sage: elements.remove(G("()"))
sage: G.list()
[(1,2)]
sage: K = SymmetricGroup(2)
sage: K.list()
[(1,2)]

as reported at http://groups.google.com/group/sage-devel/browse_thread/thread/265e134a585cf2bf

CC: @rbeezer @fchapoton

Component: group theory

Author: Jori Mäntysalo

Branch/Commit: ae820df

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/9155
@mezzarobba
Copy link
Member

comment:2

See also #10927.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Apr 22, 2016

comment:3

This bug has been corrected. (#10927 is another thing,)

@jm58660 jm58660 mannequin added the s: needs review label Apr 22, 2016
@jm58660
Copy link
Mannequin

jm58660 mannequin commented Apr 29, 2016

Branch: u/jmantysalo/g_list___can_be_modified

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Apr 29, 2016

comment:5

Test added as suggested in email.

New commits:

ae820dfTest for #9155.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Apr 29, 2016

Commit: ae820df

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Apr 29, 2016

Author: Jori Mäntysalo

@jm58660 jm58660 mannequin added t: enhancement and removed t: bug labels Apr 29, 2016
@jm58660 jm58660 mannequin added this to the sage-7.2 milestone Apr 29, 2016
@jm58660 jm58660 mannequin added c: group theory and removed c: algebra labels Apr 29, 2016
@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:6

ok, let it be, thanks

@vbraun
Copy link
Member

vbraun commented May 1, 2016

Changed branch from u/jmantysalo/g_list___can_be_modified to ae820df

@vbraun vbraun closed this as completed in 5240bd0 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghitza aghitza

Labels
c: group theory p: trivial / 5 t: enhancement
Projects
None yet
Milestone
sage-7.2
Development

No branches or pull requests
5 participants
@robertwb @aghitza @vbraun @mezzarobba @fchapoton