Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cygwin/ARM:pynac.pyx use double precision special functions instead of long double (REVISITED) #9162

Closed
williamstein opened this issue Jun 7, 2010 · 7 comments

Comments

@williamstein
Copy link
Contributor

This is a followup to #8847, which was supposed to fix this, but simply didn't.


sage -t  "devel/sage/sage/functions/other.py"               
**********************************************************************
File "/home/wstein/sage-4.4.3/devel/sage/sage/functions/other.py", line 475:
    sage: gamma1(float(6))
Expected:
    120.0
Got:
    119.99999999999997
**********************************************************************
1 items had failures:
   1 of  29 in __main__.example_12

See #8847 for more details. Fixed by #12449.

CC: @SnarkBoojum

Component: porting: Cygwin

Reviewer: Burcin Erocal

Issue created by migration from https://trac.sagemath.org/ticket/9162

@williamstein williamstein added this to the sage-5.0 milestone Jun 7, 2010
@williamstein williamstein changed the title cygwin: cygwin:pynac.pyx use double precision special functions instead of long double (REVISITED) Jun 7, 2010
@mwhansen
Copy link
Contributor

mwhansen commented Jun 7, 2010

comment:2

I don't think that #8847 was supposed to fix this. #8847 was to make it so that we get 120.0 instead of 119.99999999999997 on Linux. Cygwin has always given 119.9999...

@kcrisman
Copy link
Member

kcrisman commented Aug 2, 2011

comment:3

Somewhat miraculously, this passes tests on a recent build of mine on XP. Perhaps due to using mpmath now or something?

@kcrisman
Copy link
Member

comment:5

But this, once again, does not pass when done by hand. What is going on?

@dimpase
Copy link
Member

dimpase commented Jan 17, 2012

comment:6

exactly the same problem also pops up on ARM running Ubuntu 11.10.

@dimpase dimpase changed the title cygwin:pynac.pyx use double precision special functions instead of long double (REVISITED) cygwin/ARM:pynac.pyx use double precision special functions instead of long double (REVISITED) Jan 17, 2012
@burcin
Copy link

burcin commented Feb 13, 2012

comment:8

#12449 contains a patch to fix. We should close this as a duplicate.

@burcin burcin removed this from the sage-5.0 milestone Feb 13, 2012
@jdemeyer
Copy link

Reviewer: Burcin Erocal

@jdemeyer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants