Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve doctest coverage of databases/conway.py #9222

Closed
aghitza opened this issue Jun 12, 2010 · 9 comments
Closed

improve doctest coverage of databases/conway.py #9222

aghitza opened this issue Jun 12, 2010 · 9 comments

Comments

@aghitza
Copy link

aghitza commented Jun 12, 2010

As of sage-4.4.3:

----------------------------------------------------------------------
conway.py
ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE conway.py: 0% (0 of 7)

Missing documentation:
 * _init(self):
 * __repr__(self):
 * polynomial(self, p, n):
 * has_polynomial(self, p, n):
 * primes(self):
 * degrees(self, p):

Missing doctests:
 * __init__(self, read_only=True):

----------------------------------------------------------------------

CC: @sagetrac-mvngu

Component: doctest coverage

Keywords: conway polynomial database

Author: Alex Ghitza

Reviewer: David Loeffler

Merged: sage-4.5.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/9222

@aghitza aghitza added this to the sage-4.5.2 milestone Jun 12, 2010
@aghitza
Copy link
Author

aghitza commented Jun 12, 2010

Author: Alex Ghitza

@aghitza
Copy link
Author

aghitza commented Jun 12, 2010

comment:2

After the patch:

ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE conway.py: 85% (6 of 7)

Missing documentation:
	 * _init(self):

I'm not convinced a TestSuite test makes sense here (and I have tried to put one in and got a pickling-related error). Also, I'm not sure what _init(self) is meant to be doing, so I'm leaving it alone for now.

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jun 14, 2010

comment:3

Looks fine to me. Tests pass and the documentation builds OK. I agree that the _init method isn't something one can reasonably doctest!

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jun 29, 2010

Reviewer: David Loeffler

@dandrake
Copy link
Contributor

comment:5

Please include ticket numbers in the commit strings of your patches!

@aghitza
Copy link
Author

aghitza commented Jul 22, 2010

comment:6

Attachment: trac_9222.patch.gz

Done.

@dandrake
Copy link
Contributor

Merged: sage-4.5.2.alpha1

@dandrake
Copy link
Contributor

comment:7

Replying to @aghitza:

Done.

Thanks!

@fchapoton

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants