Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in crystal code #9250

Closed
anneschilling opened this issue Jun 16, 2010 · 6 comments
Closed

Bug in crystal code #9250

anneschilling opened this issue Jun 16, 2010 · 6 comments
Assignees
@sagetrac-sage-combinat
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-4.5.2

Comments

@anneschilling
Copy link

This currently breaks:

sage: B=KirillovReshetikhinCrystal(['D',5,1], 3,1)
sage: B[0].e(0)

This has to do with the method intermediate_shape for plus/minus diagrams.

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: crystals

Author: Anne Schilling

Reviewer: Daniel Bump

Merged: sage-4.5.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/9250
@anneschilling
Copy link
Author

Changed keywords from none to crystals

@anneschilling
Copy link
Author

Author: Anne Schilling

@dwbump

This comment has been minimized.

Sign in to view
@dwbump
Copy link
Mannequin

dwbump mannequin commented Jun 25, 2010

Reviewer: Daniel Bump

@dwbump
Copy link
Mannequin

dwbump mannequin commented Jun 25, 2010

comment:2

Attachment: trac_9250-crystalbug-as.patch.gz

After the patch, passes sage -testall.

Fixes the crash mentioned in the Description.

Includes doctest.

Apparently the intermediate_shape method of PMDiagram presumed
that self.n was 2.

This one-line fix is obviously correct.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jul 21, 2010

Merged: sage-4.5.2.alpha0

@qed777 qed777 mannequin removed the s: positive review label Jul 21, 2010
@qed777 qed777 mannequin closed this as completed Jul 21, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin added this to the sage-4.5.2 milestone Jul 21, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-sage-combinat sagetrac-sage-combinat

Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.5.2
Development

No branches or pull requests
1 participant
@anneschilling