Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib should be a prerequisite for libpng #9456

Closed
jhpalmieri opened this issue Jul 8, 2010 · 12 comments
Closed

zlib should be a prerequisite for libpng #9456

jhpalmieri opened this issue Jul 8, 2010 · 12 comments

Comments

@jhpalmieri
Copy link
Member

From the libpng INSTALL file:

Before installing libpng, you must first install zlib

So fix the file "deps" accordingly. (This issue arose when building spkg's in parallel: the build failed when it reached libpng because zlib wasn't installed yet.)

CC: @sagetrac-drkirkby

Component: distribution

Author: John Palmieri

Reviewer: David Kirkby

Merged: sage-4.5.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/9456

@jhpalmieri jhpalmieri added this to the sage-4.5.2 milestone Jul 8, 2010
@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jul 8, 2010

comment:1

That's perfectly logical. Positive review.

@jhpalmieri
Copy link
Member Author

comment:3

I'm upgrading this to a blocker because there is a patch and I hit it every time I try to build sage on the skynet machine iras with parallel spkg building: the build fails on libpng, then I have to restart it. (Usually libpng and zlib are built at the same time on this machine, so after libpng fails, zlib builds successfully, so running "make" again works fine.)

@dandrake
Copy link
Contributor

comment:4

I've put the deps file here in SAGE_ROOT/spkg/standard for 4.5.2.alpha1.

@dandrake
Copy link
Contributor

Reviewer: David Kirkby

@dandrake
Copy link
Contributor

Merged: sage-4.5.2.alpha1

@dandrake
Copy link
Contributor

Author: John Palmieri

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jul 26, 2010

comment:5

I'm sorry, I have screwed up here, and attached these files to the wrong ticket! Instead of attaching them to #9598, I've attached them here.

Since this has not been merged, it's probably not a fatal screw up. Sorry.

I will attempt to put the files back as they should be.

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jul 26, 2010

comment:6

Replying to @sagetrac-drkirkby:

Since this has not been merged, it's probably not a fatal screw up. Sorry.

I mean it has been merged, so it should not be a big deal. But I will attempt to put the files back as they should be.

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jul 26, 2010

comment:7

I've tried to correct this, but have failed. I'm going to delete this, and raise it on sage-devel.

Dave

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jul 26, 2010

Attachment: deps.gz

spkg/standard/deps file, written by John and merged into sage-4.5.2.alpha1 which I overwrote by mistake. I'm 99% sure this is right.

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jul 26, 2010

Attachment: deps.diff.gz

diff of spkg/standard/deps written by john which I overwrote by mistake. I'm 99% sure this is right.

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jul 26, 2010

comment:8

I believe these are correct. Perhaps someone else can check.

Dave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants