Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning in matrix_modn_dense.pyx #9462

Closed
wjp mannequin opened this issue Jul 9, 2010 · 6 comments
Closed

warning in matrix_modn_dense.pyx #9462

wjp mannequin opened this issue Jul 9, 2010 · 6 comments
Assignees
@sagetrac-GeorgSWeber
Labels
c: build p: minor / 4 t: bug
Milestone
sage-4.5.2

Comments

@wjp
Copy link
Mannequin

wjp mannequin commented Jul 9, 2010

cython gives a warning when compiling matrix_modn_dense.pyx:

warning: /data2/wpalenst/sage-4.5.alpha4/devel/sage-main/sage/matrix/matrix_modn_dense.pyx:105:8: Function signature does not match previous declaration

I've uploaded a patch that removes the duplicate declaration (of memcpy), and also removes the unused declaration of memcmp.

Component: build

Author: Willem Jan Palenstijn

Reviewer: John Palmieri

Merged: sage-4.5.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/9462
@wjp wjp mannequin added this to the sage-5.0 milestone Jul 9, 2010
@wjp wjp mannequin added c: build labels Jul 9, 2010
@wjp wjp mannequin assigned sagetrac-GeorgSWeber Jul 9, 2010
@wjp

This comment has been minimized.

Sign in to view
@wjp
Copy link
Mannequin Author

wjp mannequin commented Jul 9, 2010

comment:1

Attachment: trac_9462_duplicate_decl.patch.gz

@wjp wjp mannequin added the s: needs review label Jul 9, 2010
@wjp wjp mannequin modified the milestones: sage-5.0, sage-4.5.1 Jul 17, 2010
@jhpalmieri
Copy link
Member

comment:3

The patch makes the warning go away and all tests pass afterwards. Since the declaration is already included via include "../ext/cdefs.pxi", getting rid of the extra one looks fine. Positive review.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

Author: Willem Jan Palenstijn

@dandrake
Copy link
Contributor

Merged: sage-4.5.2.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-GeorgSWeber sagetrac-GeorgSWeber

Labels
c: build p: minor / 4 t: bug
Projects
None yet
Milestone
sage-4.5.2
Development

No branches or pull requests
2 participants
@dandrake @jhpalmieri