Crypto lattice basis generator

[sagetrac-rlindner]

We introduce a generator for different types of integral lattice bases of row vectors relevant in cryptography.

It offers more variety and better usability than fplll's generator.

Contacts:
Richard Lindner rlindner@cdc.informatik.tu-darmstadt.de
Michael Schneider mischnei@cdc.informatik.tu-darmstadt.de

Component: cryptography

Keywords: lattices

Author: Richard Lindner, Michael Schneider

Reviewer: Martin Albrecht, Richard Lindner

Merged: sage-4.5.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/9496

[malb]

comment:1

I think overall it looks fine, some small points:

• I think the function is too specialised to be in the main namespace, how about crypto.generate_lattice ?
• Could you break lines around 80 characters?
• One shouldn't need to pass a seed, but instead just change the seed with set_random_seed()
• Id' rename ntl_flag to ntl

[sagetrac-rlindner]

comment:3

Specifically:

• function is now: sage.crypto.gen_lattice()
• lines are broken at 79 chars
• set_random_seed() is honored, but option to use seed remains
• _flag indicator is removed

[malb]

comment:4

Hi, I'm having trouble applying your patch on top of the other, many hunks fail. Did you forget to include an intermediate patch (14533?)? Or can you provide a patch with everything rolled into one patch?

[sagetrac-rlindner]

Candidate #2

[sagetrac-rlindner]

comment:5

Attachment: 14532.patch.gz

I recreated 14532.patch to include all changes and could not delete the other file, so I did the next best thing.

[malb]

apply after other patch

[malb]

comment:6

Attachment: trac_9496_referee.patch.gz

I've just uploaded a referee patch which should be applied on top of your patch. It fixes a few formating issues I probably could do quicker than you. 

Note that this means that I cannot give this ticket a positive review anymore, I cannot referee my own patch. However, since I sign off on your patch iff my patch is applied afterwards, you can review my patch, i.e. accept my changes. Of course, if you have anything to criticise go for it!

[malb]

comment:7

btw. this is how the result looks like:

http://sage.math.washington.edu/home/malb/scratch_sage/sage-4.4/devel/sage/doc/output/html/en/reference/sage/crypto/lattice.html

[sagetrac-rlindner]

comment:9

Looks so much better, thanks!

[qed777]

comment:11

I've updated the Author(s) and Reviewer(s) fields with guesses. Please correct them, if I'm wrong.

[qed777]

Changed author from Richard Lindner, Michael Schneider to Richard Lindner, Michael Schneider, Martin Albrecht

[qed777]

Reviewer: Martin Albrecht, Richard Lindner

[qed777]

Merged: sage-4.5.2.alpha0

[malb]

comment:12

I didn't do much

[malb]

Changed author from Richard Lindner, Michael Schneider, Martin Albrecht to Richard Lindner, Michael Schneider

[sagetrac-rlindner]

Attachment: 14604.patch.gz

An addtional patch to fix some bugs in the dual lattice generation/ description. Candidate 3

[malb]

comment:13

Please open a new ticket for your bugfix since this ticket is already closed. Btw.:

sage: A
[   1    5   -3    1]
[-290  -14    1    1]
[ -13   -6    6   -1]
[  15   -1    3   62]

sage: A.matrix_from_rows(range(A.nrows())[::-1])
[  15   -1    3   62]
[ -13   -6    6   -1]
[-290  -14    1    1]
[   1    5   -3    1]