New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The function _factor_over_nonprime_finite_field is wrong in Sage, so remove it #9498
Comments
comment:1
Look into whether the comment malb posted on #5074 is really just an indication of a bug in this code, and not in Singular. |
Attachment: trac_9498-rebased_to_apply_after_5074.patch.gz |
comment:2
Attachment: trac_9498.patch.gz |
comment:3
Looks good to me. Since there seems to be no movement on #5074 -- I guess we're waiting for the Singular performance bug to be resolved -- let's at least deal with this ticket. I tested |
Reviewer: David Loeffler |
Author: William Stein |
Attachment: trac_9498.2.patch.gz Same patch, fixed commit message |
Merged: sage-4.6.2.alpha1 |
I wrote the function _factor_over_nonprime_finite_field in multi_polynomial.pyx in hopes that Singular's multivariate poly factorization worked over GF(p). But it doesn't, so that function is pointless. Moreover, as John Cremona pointed out in email on the sagedays23 list recently, the algorithm there is wrong!:
Here's an example to illustrate that it is wrong:
The point is that g should factor as a product of two linear factors.
So, let's just delete this function, and anything that calls it, and use Singular's builtin factorization code in the non-prime case.
Component: commutative algebra
Author: William Stein
Reviewer: David Loeffler
Merged: sage-4.6.2.alpha1
Issue created by migration from https://trac.sagemath.org/ticket/9498
The text was updated successfully, but these errors were encountered: