Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage/symbolic/random_tests.py wrongly depends on order of dict.values() #9514

Closed
sagetrac-cwitty mannequin opened this issue Jul 16, 2010 · 5 comments
Closed

sage/symbolic/random_tests.py wrongly depends on order of dict.values() #9514

sagetrac-cwitty mannequin opened this issue Jul 16, 2010 · 5 comments

Comments

@sagetrac-cwitty
Copy link
Mannequin

sagetrac-cwitty mannequin commented Jul 16, 2010

The variable sage.symbolic.random_tests.full_functions is ordered in the same order as the .values() method on a dict, which is not necessarily reproducible. (I'm a little curious as to why the order in fact does seem to be reproducible, across multiple platforms, etc., but changes with the addition of seemingly unrelated code -- but not curious enough to investigate.)

Anyway, the current code is clearly wrong. I'll have a fix in a few minutes.

This should fix the strange random_tests.py doctest issue from #8988, and possibly reduce the churn in the random_tests doctest results.

Component: symbolics

Author: Carl Witty

Reviewer: Andrey Novoseltsev

Merged: sage-4.5.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/9514

@sagetrac-cwitty sagetrac-cwitty mannequin added this to the sage-4.5.2 milestone Jul 16, 2010
@sagetrac-cwitty sagetrac-cwitty mannequin self-assigned this Jul 16, 2010
@sagetrac-cwitty
Copy link
Mannequin Author

sagetrac-cwitty mannequin commented Jul 16, 2010

comment:1

Attachment: trac_9514-random-tests-sort-functions.patch.gz

This patch fixes the problem, and also seems to fix the random_tests.py problem with #8988 (as expected).

@sagetrac-cwitty
Copy link
Mannequin Author

sagetrac-cwitty mannequin commented Jul 16, 2010

Author: Carl Witty

@novoselt
Copy link
Member

comment:2

Works for me and removes the necessity of interfering in #8988.

@novoselt
Copy link
Member

Reviewer: Andrey Novoseltsev

@qed777
Copy link
Mannequin

qed777 mannequin commented Jul 20, 2010

Merged: sage-4.5.2.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant