Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spkg-check for gsl does not cause an exit on errors. #9531

Closed
sagetrac-drkirkby mannequin opened this issue Jul 17, 2010 · 2 comments
Closed

spkg-check for gsl does not cause an exit on errors. #9531

sagetrac-drkirkby mannequin opened this issue Jul 17, 2010 · 2 comments

Comments

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jul 17, 2010

The spkg-check file for GNU Scientific Library (GSL) consists of:

#!/usr/bin/env bash

cd src

make check

if [ $? -ne 0 ]; then
   echo "Error: make check for GSL failed"
fi

so the Sage build does not exit if make check fails. This is in contrast to virtually all other spkg-check files, where they would have:

make check

if [ $? -ne 0 ]; then
   echo "Error: make check for GSL failed"
   exit 1
fi

The version of GSL in Sage happens to be almost 3 years old too.

Dave

Component: spkg-check

Issue created by migration from https://trac.sagemath.org/ticket/9531

@sagetrac-drkirkby sagetrac-drkirkby mannequin added this to the sage-4.5.3 milestone Jul 17, 2010
@sagetrac-drkirkby sagetrac-drkirkby mannequin self-assigned this Jul 17, 2010
@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Jul 18, 2010

comment:1

I've created #9533 to update the version of GSL and to fix the spkg-check issues at the same time. When #9533 is merged, this ticket can be closed.

@qed777
Copy link
Mannequin

qed777 mannequin commented Aug 15, 2010

comment:2

I'm closing this as a "duplicate" of #9533.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants