Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix uncontrolled randomness in sage/graphs #9532

Closed
sagetrac-cwitty mannequin opened this issue Jul 17, 2010 · 6 comments
Closed

fix uncontrolled randomness in sage/graphs #9532

sagetrac-cwitty mannequin opened this issue Jul 17, 2010 · 6 comments
Assignees
@sagetrac-cwitty
Labels
c: graph theory p: major / 3 t: bug
Milestone
sage-4.5.2

Comments

@sagetrac-cwitty
Copy link
Mannequin

sagetrac-cwitty mannequin commented Jul 17, 2010

There are several places in sage/graphs that use random numbers that aren't under the control of randstate.pyx. I'm going to fix them now.

CC: @rlmill

Component: graph theory

Author: Carl Witty

Reviewer: Robert Miller

Merged: sage-4.5.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/9532
@sagetrac-cwitty sagetrac-cwitty mannequin added this to the sage-4.5.2 milestone Jul 17, 2010
@sagetrac-cwitty sagetrac-cwitty mannequin self-assigned this Jul 17, 2010
@sagetrac-cwitty
Copy link
Mannequin Author

sagetrac-cwitty mannequin commented Jul 17, 2010

Attachment: trac_9532-graphs-randstate.patch.gz

@sagetrac-cwitty
Copy link
Mannequin Author

sagetrac-cwitty mannequin commented Jul 17, 2010

comment:1

OK, the patch is up. I fixed all the randomness I found (except for two calls in two versions of random_stress, which I left alone except for a comment).

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jul 19, 2010

comment:2

Looks good to me.

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jul 19, 2010

Reviewer: Robert Miller

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jul 19, 2010

Author: Carl Witty

@qed777
Copy link
Mannequin

qed777 mannequin commented Jul 21, 2010

Merged: sage-4.5.2.alpha0

@qed777 qed777 mannequin removed the s: positive review label Jul 21, 2010
@qed777 qed777 mannequin closed this as completed Jul 21, 2010
@sagetrac-cwitty sagetrac-cwitty mannequin mentioned this issue Aug 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-cwitty sagetrac-cwitty

Labels
c: graph theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.5.2
Development

No branches or pull requests
0 participants