Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add base method for permutation groups #9534

Closed
sagetrac-jasonbhill mannequin opened this issue Jul 17, 2010 · 14 comments
Closed

add base method for permutation groups #9534

sagetrac-jasonbhill mannequin opened this issue Jul 17, 2010 · 14 comments

Comments

@sagetrac-jasonbhill
Copy link
Mannequin

sagetrac-jasonbhill mannequin commented Jul 17, 2010

Patch to add a (working) base method for permutation groups.


Apply attachment: trac_9534-permgroup_base.patch to the Sage library.

Depends on #10334
Depends on #10335

Component: group theory

Keywords: base

Author: Jason Hill

Reviewer: Mike Hansen

Merged: sage-4.7.2.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/9534

@sagetrac-jasonbhill sagetrac-jasonbhill mannequin added this to the sage-5.0 milestone Jul 17, 2010
@sagetrac-jasonbhill sagetrac-jasonbhill mannequin self-assigned this Jul 17, 2010
@sagetrac-jasonbhill
Copy link
Mannequin Author

sagetrac-jasonbhill mannequin commented Jul 18, 2010

comment:1

The existing base method returned "Integer Ring" for all permutation groups as it was inherited from ParentWithBase. This new base method uses GAP's base from stabilizer chain method to return an actual base, with an optional seed.

The patch was placed in the combinat queue as it depends on Mike Hansen's domain modifications.

@mwhansen
Copy link
Contributor

Changed author from jasonbhill to Jason Hill

@mwhansen
Copy link
Contributor

Reviewer: Mike Hansen

@mwhansen

This comment has been minimized.

@mwhansen
Copy link
Contributor

comment:2

This is actually Jason's code, and it looks good to me.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Jun 1, 2011

comment:4

Attachment: trac_9534-permgroup_base.patch.gz

@jdemeyer
Copy link

jdemeyer commented Jun 1, 2011

Dependencies: #10334, #10335

@jdemeyer jdemeyer modified the milestones: sage-5.0, sage-4.7.1, sage-4.7.2 Jun 10, 2011
@jdemeyer
Copy link

Merged: sage-4.7.2.alpha0

@jdemeyer
Copy link

jdemeyer commented Aug 1, 2011

comment:8

Unmerged because of an issue with #10335.

@jdemeyer
Copy link

jdemeyer commented Aug 1, 2011

Changed merged from sage-4.7.2.alpha0 to none

@jdemeyer jdemeyer reopened this Aug 1, 2011
@jdemeyer jdemeyer removed this from the sage-4.7.2 milestone Aug 1, 2011
@nexttime

This comment has been minimized.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 23, 2011

comment:11

Does this now have to be rebased on (the rebased) #10335?

In case it does, one should set it to "needs work", otherwise the milestone should be changed to Sage 4.7.2 again.

@jdemeyer
Copy link

jdemeyer commented Oct 7, 2011

Merged: sage-4.7.2.alpha4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants